Skip to content

Rework null adapter into mock adapter #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 11, 2024

Conversation

aarongreig
Copy link
Contributor

This also comes with a new accompanying helper header which allows tests to override entry points and create their own reference counted dummy handles.

@github-actions github-actions bot added loader Loader related feature/bug images UR images specification Changes or additions to the specification experimental Experimental feature additions/changes/specification command-buffer Command Buffer feature addition/changes/specification labels Jun 24, 2024
@aarongreig
Copy link
Contributor Author

@pbalcer This is a working (insofar as I have one of the sycl unittest suites passing with it) prototype of the mock adapter + header approach. The interesting stuff is in scripts/core/loader.yml where there's a new loader entry point to force load the mock adapter (and the implementation for that in source/loader/ur_lib.cpp) and in source/mock where the mock interface header lives. If the overall approach looks ok to you I'll come back to polish and add docs/testing

Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Much cleaner than trying to shoehorn this functionality into a layer :)

@aarongreig aarongreig force-pushed the aaron/mockAdapter branch from 23e98a1 to 9b5d16c Compare July 2, 2024 11:26
@aarongreig aarongreig marked this pull request as ready for review July 2, 2024 11:27
@aarongreig aarongreig requested review from a team as code owners July 2, 2024 11:27
@aarongreig
Copy link
Contributor Author

this is now complete with docs and testing, it depends on #1720 but since that's a NFC I'll be able to merge it pretty soon

Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@isaacault isaacault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the changes added from reviews in #1720, this LGTM.

@github-actions github-actions bot added the conformance Conformance test suite issues. label Jul 2, 2024
@aarongreig aarongreig force-pushed the aaron/mockAdapter branch 5 times, most recently from 532e2b4 to 95837b0 Compare July 8, 2024 12:02
@aarongreig aarongreig force-pushed the aaron/mockAdapter branch from 0f8dead to 7077025 Compare July 9, 2024 15:56
@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label Jul 10, 2024
This also comes with a new accompanying helper header which allows tests
to override entry points and create their own reference counted dummy
handles.
@kbenzie kbenzie force-pushed the aaron/mockAdapter branch from d2924f7 to 2bc0e0a Compare July 11, 2024 09:50
@kbenzie kbenzie merged commit 76c6bf9 into oneapi-src:main Jul 11, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command-buffer Command Buffer feature addition/changes/specification conformance Conformance test suite issues. experimental Experimental feature additions/changes/specification images UR images loader Loader related feature/bug ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants