-
Notifications
You must be signed in to change notification settings - Fork 125
Rework null adapter into mock adapter #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pbalcer This is a working (insofar as I have one of the sycl unittest suites passing with it) prototype of the mock adapter + header approach. The interesting stuff is in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Much cleaner than trying to shoehorn this functionality into a layer :)
26c0a40
to
74cceed
Compare
23e98a1
to
9b5d16c
Compare
this is now complete with docs and testing, it depends on #1720 but since that's a NFC I'll be able to merge it pretty soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending the changes added from reviews in #1720, this LGTM.
532e2b4
to
95837b0
Compare
0f8dead
to
7077025
Compare
7077025
to
d2924f7
Compare
This also comes with a new accompanying helper header which allows tests to override entry points and create their own reference counted dummy handles.
This way any override for these entry points from an application will take precedence over our defaults.
d2924f7
to
2bc0e0a
Compare
This also comes with a new accompanying helper header which allows tests to override entry points and create their own reference counted dummy handles.