Fix mock on Windows, add logging of adapter load/unload #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
aarongreig
approved these changes
Jul 16, 2024
pbalcer
approved these changes
Jul 16, 2024
Change the value of the `mock_platform_name` to avoid mismatches in string size when using replacement entry points in mock tests. Also add logging of adapter load and unload as this proved useful in tracking down this issue & will enable fixes of other tests.
kbenzie
force-pushed
the
benie/fix-win-mock
branch
from
9aab539 to
ff47a03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the value of the
mock_platform_nameto avoid mismatches in string size when using replacement entry points in mock tests.Also add logging of adapter load and unload as this proved useful in tracking down this issue & will enable fixes of other tests.