[L0] fix Coverity issues for L0 Adapter #1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Aug 9, 2024
nrspruit
commented
- Fixed recast of Queue object vs usage of variable.
- fixed usm alignment check such that == 0 is correctly skipped from buffer overrun checks.
- fixed cast to show no need to check the return from decrement and test in queue finish.
- fixed release of resources for bindless import on error.
- Fixed recast of Queue object vs usage of variable. - fixed usm alignment check such that == 0 is correctly skipped from buffer overrun checks. - fixed cast to show no need to check the return from decrement and test in queue finish. - fixed release of resources for bindless import on error. Signed-off-by: Neil R. Spruit <[email protected]>
igchor
approved these changes
Aug 9, 2024
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Aug 9, 2024
-pre-commit PR for: oneapi-src/unified-runtime#1955 Signed-off-by: Neil R. Spruit <[email protected]>
isaacault
approved these changes
Aug 12, 2024
|
Tagging @wenju-he to test this. |
cppchedy
approved these changes
Aug 12, 2024
A subset of vulkan/dx12 interop tests are passing on DG2 Windows. |
omarahmed1111
pushed a commit
to nrspruit/llvm
that referenced
this pull request
Aug 13, 2024
-pre-commit PR for: oneapi-src/unified-runtime#1955 Signed-off-by: Neil R. Spruit <[email protected]>
53 tasks
kbenzie
pushed a commit
that referenced
this pull request
Aug 13, 2024
[L0] fix Coverity issues for L0 Adapter
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Aug 13, 2024
-pre-commit PR for: oneapi-src/unified-runtime#1955 Signed-off-by: Neil R. Spruit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.