[UR] Fix correct usage of In Order sync list given counting events #2430
Conversation
-pre-commit PR for: oneapi-src/unified-runtime#2430 Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
fix_inorder_initList
branch
from
6405c51 to
3467780
Compare
-pre-commit PR for: oneapi-src/unified-runtime#2430 Signed-off-by: Neil R. Spruit <[email protected]>
| ze_command_list_handle_t ZeCommandListForInit = | ||
| UrContext->ZeCommandListInit; | ||
| if (InOrderListRequired) { | ||
| ZeCommandListForInit = UrContext->ZeCommandListInitInOrder; |
There was a problem hiding this comment.
can we just create the correct type of cmdlist in the first place in UrContext->ZeCommandListInit? Will there ever be a situation where two different queues in a single context require different types of events (thus command lists)?
There was a problem hiding this comment.
the user can request an out of order queue so the envs would not be taken so we would have an out of order queue, then an in order immediate command list being used for init.
There is no "correct" in this case. They would be different in this case anyways.
If we want the init list to always be determined by the defaults of the two envs, then we can change this such that if the envs are set, then the init command list is also in order.
I was worried about the impact of performance for these calls, but if that is not a concern, then this can be made that way.
There was a problem hiding this comment.
@pbalcer , please re-review, I decided to just simplify to the single list when both envs are set. that would then be a catch all. Less configurable to swap inbetween, but this is cleaner.
There was a problem hiding this comment.
lgtm, thanks for making the changes!
nrspruit
force-pushed
the
fix_inorder_initList
branch
from
3467780 to
a25acd3
Compare
-pre-commit PR for: oneapi-src/unified-runtime#2430 Signed-off-by: Neil R. Spruit <[email protected]>
-pre-commit PR for: oneapi-src/unified-runtime#2430 Signed-off-by: Neil R. Spruit <[email protected]>
- Fixes a race condition when the wait events are counting events when executing the context's synchronous immediate command list. - If a counting event is used in a non immediate command list, then an error will be returned. - Given both InOrderLists and CounterBasedEvents is enabled, then the context init command list will not be inorder. Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
fix_inorder_initList
branch
from
a25acd3 to
08acf05
Compare
-pre-commit PR for: oneapi-src/unified-runtime#2430 Signed-off-by: Neil R. Spruit <[email protected]>
|
Created intel/llvm PR for this intel/llvm#16327 |
Uh oh!
There was an error while loading. Please reload this page.