Fix calls to ze destructors in level-zero adapter v2 #2531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
Jan 14, 2025
| @@ -90,19 +96,19 @@ struct ze_handle_wrapper { | |||
| }; | |||
|
|
|||
| using ze_kernel_handle_t = | |||
| ze_handle_wrapper<::ze_kernel_handle_t, zeKernelDestroy>; | |||
| ze_handle_wrapper<::ze_kernel_handle_t, zeKernelDestroy, 0>; | |||
There was a problem hiding this comment.
yeah, no, this is too awkward to use ;) I'd rather we create some sort of macro (or some clever lambda as parametr, dunno) that wraps all the destroy functions and calls ZE_CALL_NOCHECK inside of the wrapper.
igchor
approved these changes
Jan 14, 2025
pbalcer
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using level zero v2 adapter, all destructions reported with use of UR_L0_DEBUG flag are labeled as "destroy(handle)". It provides no information on which objects are destroyed and which level zero functions are called. It also breaks leak detection using UR_L0_LEAKS_DEBUG flag - it does not report any objects freed this way.
This is a bit crude workaround, however I wasn't able to come up with any cleaner solution.