Use UMF Proxy pool manager with UMF CUDA memory provider in UR #2659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
changed the title
github-actions
bot
added
common
ldorau
force-pushed
the
Use_UMF_Proxy_pool_manager_with_UMF_CUDA_memory_provider_in_UR
branch
from
d202b5c to
84eba18
Compare
This was referenced Feb 5, 2025
ldorau
force-pushed
the
Use_UMF_Proxy_pool_manager_with_UMF_CUDA_memory_provider_in_UR
branch
from
84eba18 to
5538916
Compare
github-actions
bot
added
ci/cd
ldorau
force-pushed
the
Use_UMF_Proxy_pool_manager_with_UMF_CUDA_memory_provider_in_UR
branch
16 times, most recently
from
ea11b3b to
5e6797b
Compare
ldorau
force-pushed
the
Use_UMF_Proxy_pool_manager_with_UMF_CUDA_memory_provider_in_UR
branch
5 times, most recently
from
0057c3a to
da6f5a7
Compare
bratpiorka
reviewed
Feb 13, 2025
|
llvm build: intel/llvm#17015 |
igchor
reviewed
Feb 13, 2025
UMF Proxy pool manager is just a wrapper for the UMF memory provider (CUDA memory provider in this case) plus it adds also tracking of memory allocations. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Use_UMF_Proxy_pool_manager_with_UMF_CUDA_memory_provider_in_UR
branch
from
dee5c21 to
40af3bc
Compare
bratpiorka
approved these changes
Feb 14, 2025
omarahmed1111
approved these changes
Feb 14, 2025
|
@igchor Please re-review and resolve your issues. |
|
@frasercrmck @npmiller please review |
npmiller
approved these changes
Feb 17, 2025
igchor
reviewed
Feb 18, 2025
| @@ -301,10 +324,9 @@ inline ur_result_t umf2urResult(umf_result_t umfResult) { | |||
| }; | |||
| } | |||
|
|
|||
| inline umf_result_t createMemoryProvider( | |||
| inline umf_result_t setCUMemoryProviderParams( | |||
There was a problem hiding this comment.
This should be in source/adapters/cuda/common.hpp
There was a problem hiding this comment.
Fixed in intel/llvm#17015.
@igchor Done
igchor
approved these changes
Feb 18, 2025
|
PR moved to intel/llvm#17015 |
Can this be closed now? |
|
Moved to intel/llvm#17015 |
Closed |
kbenzie
pushed a commit
to intel/llvm
that referenced
this pull request
Feb 21, 2025
… in UR (#17015) Use UMF Proxy pool manager with UMF CUDA memory provider in UR. UMF Proxy pool manager is just a wrapper for the UMF memory provider (CUDA memory provider in this case) plus it adds also tracking of memory allocations. Moved from: oneapi-src/unified-runtime#2659 Signed-off-by: Lukasz Dorau <[email protected]>
kbenzie
pushed a commit
to kbenzie/unified-runtime
that referenced
this pull request
Feb 21, 2025
Use UMF Proxy pool manager with UMF CUDA memory provider in UR. UMF Proxy pool manager is just a wrapper for the UMF memory provider (CUDA memory provider in this case) plus it adds also tracking of memory allocations. Moved from: oneapi-src#2659 Signed-off-by: Lukasz Dorau <[email protected]>
kurapov-peter
pushed a commit
to kurapov-peter/llvm
that referenced
this pull request
Mar 5, 2025
… in UR (intel#17015) Use UMF Proxy pool manager with UMF CUDA memory provider in UR. UMF Proxy pool manager is just a wrapper for the UMF memory provider (CUDA memory provider in this case) plus it adds also tracking of memory allocations. Moved from: oneapi-src/unified-runtime#2659 Signed-off-by: Lukasz Dorau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use UMF Proxy pool manager with UMF CUDA memory provider in UR.
UMF Proxy pool manager is just a wrapper for the UMF memory provider
(CUDA memory provider in this case) plus it adds also tracking of memory
allocations.
llvm build: intel/llvm#17015
Requires: