Upgrade go to 1.20 #320
Merged
Upgrade go to 1.20 #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lennysgarage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lennysgarage
force-pushed
the
upgrade-go-20
branch
4 times, most recently
from
85497c7 to
cfd42b3
Compare
|
@lennysgarage @chenz4027 I would suggest to update channel repo first. Once it is done, pick up the latest version of channel repo in the subscription repo. |
Signed-off-by: Jonathan Marcantonio <[email protected]> Update k8s.io apis to v0.25.7 Signed-off-by: Jonathan Marcantonio <[email protected]> update client-go Signed-off-by: Jonathan Marcantonio <[email protected]> update linter Signed-off-by: Jonathan Marcantonio <[email protected]> Update linter again Signed-off-by: Jonathan Marcantonio <[email protected]> musttag linter Signed-off-by: Jonathan Marcantonio <[email protected]> Never backported this change Signed-off-by: Jonathan Marcantonio <[email protected]> Update channel in go.mod Signed-off-by: Jonathan Marcantonio <[email protected]>
lennysgarage
force-pushed
the
upgrade-go-20
branch
from
cfd42b3 to
ad88d86
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonathan Marcantonio [email protected]
Updates golangci-lint from
v1.46.2tov1.51.2As well upgrades these k8s apis to their latest patch version from
v0.25.2tov0.25.7An additional space has been added to many comments due to an update with the
gofmtcommand in 1.20. As well mentions of//nolintneeded to be changed to//nolint:all, golang/vscode-go#2477 (comment).Addresses: