Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Implement Objectstore TLS support #418

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

fxiang1
Copy link
Contributor

@fxiang1 fxiang1 commented Jan 10, 2025

  • I have taken backward compatibility into consideration.
  • Add Channel insecureSkipVerify support for Objectbucket
  • Add Channel configMapRef support for TLS certs
  • insecureSkipVerify will override cert when both are specified

Example channel:

apiVersion: apps.open-cluster-management.io/v1
kind: Channel
metadata:
  name: object-dev
  namespace: ch-object-dev
spec:
  type: ObjectBucket
  pathname: https://s3.console.aws.amazon.com/s3/buckets/feng-bucket
  secretRef:
    name: secret-dev
  insecureSkipVerify: true
  configMapRef:
    name: obj-ca

Example configMap:

apiVersion: v1
kind: ConfigMap
metadata:
  name: obj-ca
  namespace: ch-object-dev
data:
  caCerts: |
    # minio root CA

    -----BEGIN CERTIFICATE-----
    ...Sample cert...
    -----END CERTIFICATE-----

Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the open-cluster-management-io org. You can then trigger verification by writing /verify-owners in a comment.

  • fxiang1
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • OWNERS

@fxiang1
Copy link
Contributor Author

fxiang1 commented Jan 10, 2025

/assign @xiangjingli

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.64%. Comparing base (a8b1cda) to head (fe4574c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
+ Coverage   55.61%   55.64%   +0.03%     
==========================================
  Files          96       96              
  Lines       15670    15742      +72     
==========================================
+ Hits         8715     8760      +45     
- Misses       6071     6100      +29     
+ Partials      884      882       -2     
Flag Coverage Δ
unit 55.64% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjingli
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 11, 2025
@xiangjingli
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Jan 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiangjingli xiangjingli merged commit ad69346 into open-cluster-management-io:main Jan 11, 2025
8 of 9 checks passed
@fxiang1 fxiang1 deleted the feng-tls branch January 13, 2025 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants