Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Sync Short lived token ArgoCD push model #421

Merged

Conversation

fxiang1
Copy link
Contributor

@fxiang1 fxiang1 commented Feb 5, 2025

  • I have taken backward compatibility into consideration.
  • Create a ManagedServiceAccount on the hub, which generates a short lived token valid for 7 days (OCP >= 4.16)
  • Delete existing long lived token if it exists

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 5, 2025
@fxiang1
Copy link
Contributor Author

fxiang1 commented Feb 5, 2025

/uncc @mikeshng

@openshift-ci openshift-ci bot removed the request for review from mikeshng February 5, 2025 15:42
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.37%. Comparing base (ad69346) to head (59d8ba7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
- Coverage   55.85%   55.37%   -0.48%     
==========================================
  Files          96       96              
  Lines       15742    15727      -15     
==========================================
- Hits         8792     8709      -83     
- Misses       6068     6141      +73     
+ Partials      882      877       -5     
Flag Coverage Δ
unit 55.37% <ø> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjingli
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 1a68f15 into open-cluster-management-io:main Feb 5, 2025
9 checks passed
@fxiang1 fxiang1 deleted the feng-token branch February 5, 2025 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants