Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Fix hub subscription pod crash on invalid cert #422

Merged

Conversation

fxiang1
Copy link
Contributor

@fxiang1 fxiang1 commented Feb 11, 2025

  • I have taken backward compatibility into consideration.
  • Changed a FatalF message output to InfoF so the hub subscription pod doesn't crash when the user provide an invalid TLS certificate

@openshift-ci openshift-ci bot requested review from jnpacker and mikeshng February 11, 2025 19:43
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fxiang1
Copy link
Contributor Author

fxiang1 commented Feb 11, 2025

/uncc @jnpacker @mikeshng

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.68%. Comparing base (1a68f15) to head (61e7eee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   55.96%   55.68%   -0.28%     
==========================================
  Files          96       96              
  Lines       15727    15727              
==========================================
- Hits         8801     8758      -43     
- Misses       6040     6088      +48     
+ Partials      886      881       -5     
Flag Coverage Δ
unit 55.68% <ø> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fxiang1
Copy link
Contributor Author

fxiang1 commented Feb 11, 2025

/cc @xiangjingli

@openshift-ci openshift-ci bot requested a review from xiangjingli February 11, 2025 20:58
@xiangjingli
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 12, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3b93f78 into open-cluster-management-io:main Feb 12, 2025
9 checks passed
@fxiang1 fxiang1 deleted the feng-podcrash branch February 12, 2025 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants