Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

add default imagePullSecrets for gitops addon #425

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

xiangjingli
Copy link
Collaborator

  • I have taken backward compatibility into consideration.

@openshift-ci openshift-ci bot requested review from fxiang1 and philipwu08 February 25, 2025 04:31
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.13%. Comparing base (678fa98) to head (99cbf57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   55.79%   56.13%   +0.34%     
==========================================
  Files          96       96              
  Lines       15727    15727              
==========================================
+ Hits         8775     8829      +54     
+ Misses       6068     6012      -56     
- Partials      884      886       +2     
Flag Coverage Δ
unit 56.13% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjingli xiangjingli merged commit 2af43d4 into main Feb 25, 2025
8 of 9 checks passed
@xiangjingli xiangjingli deleted the gitopsAddonImagePullSecrets branch February 25, 2025 05:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant