Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Clean up long lived token on hub #426

Merged

Conversation

fxiang1
Copy link
Contributor

@fxiang1 fxiang1 commented Feb 26, 2025

  • I have taken backward compatibility into consideration.
  • Delete the old secret containing the long lived token on the hub cluster

@openshift-ci openshift-ci bot requested review from chenz4027 and rokej February 26, 2025 20:02
Copy link
Contributor

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fxiang1
Copy link
Contributor Author

fxiang1 commented Feb 26, 2025

/uncc @chenz4027 @rokej

@openshift-ci openshift-ci bot removed request for chenz4027 and rokej February 26, 2025 20:02
Signed-off-by: fxiang1 <[email protected]>
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.68%. Comparing base (2bc32e9) to head (e0a297c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   55.61%   55.68%   +0.06%     
==========================================
  Files          96       96              
  Lines       15727    15742      +15     
==========================================
+ Hits         8747     8766      +19     
+ Misses       6100     6094       -6     
- Partials      880      882       +2     
Flag Coverage Δ
unit 55.68% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjingli
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 26, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 4dc6103 into open-cluster-management-io:main Feb 26, 2025
8 of 9 checks passed
@fxiang1 fxiang1 deleted the feng-secretbug branch February 26, 2025 21:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants