Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Add backup label to ArgoCD ManagedServiceAccount #428

Merged

Conversation

fxiang1
Copy link
Contributor

@fxiang1 fxiang1 commented Mar 6, 2025

  • I have taken backward compatibility into consideration.
  • Add backup label to ArgoCD ManagedServiceAccount

@openshift-ci openshift-ci bot requested review from jnpacker and lennysgarage March 6, 2025 16:39
@openshift-ci openshift-ci bot added the approved label Mar 6, 2025
@fxiang1
Copy link
Contributor Author

fxiang1 commented Mar 6, 2025

/uncc @jnpacker @lennysgarage

Signed-off-by: fxiang1 <[email protected]>
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.90%. Comparing base (8591210) to head (97d0586).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   55.65%   55.90%   +0.25%     
==========================================
  Files          96       96              
  Lines       15742    15745       +3     
==========================================
+ Hits         8761     8803      +42     
+ Misses       6100     6061      -39     
  Partials      881      881              
Flag Coverage Δ
unit 55.90% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: fxiang1 <[email protected]>
@fxiang1
Copy link
Contributor Author

fxiang1 commented Mar 6, 2025

/cc @xiangjingli

@openshift-ci openshift-ci bot requested a review from xiangjingli March 6, 2025 18:59
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ae74046 into open-cluster-management-io:main Mar 6, 2025
9 checks passed
@fxiang1 fxiang1 deleted the feng-backup branch March 6, 2025 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants