-
Notifications
You must be signed in to change notification settings - Fork 40
Add backup label to ArgoCD ManagedServiceAccount #428
Add backup label to ArgoCD ManagedServiceAccount #428
Conversation
fxiang1
commented
Mar 6, 2025
- I have taken backward compatibility into consideration.
- Add backup label to ArgoCD ManagedServiceAccount
Signed-off-by: fxiang1 <[email protected]>
/uncc @jnpacker @lennysgarage |
Signed-off-by: fxiang1 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
+ Coverage 55.65% 55.90% +0.25%
==========================================
Files 96 96
Lines 15742 15745 +3
==========================================
+ Hits 8761 8803 +42
+ Misses 6100 6061 -39
Partials 881 881
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: fxiang1 <[email protected]>
/cc @xiangjingli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fxiang1, mikeshng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ae74046
into
open-cluster-management-io:main