-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Syllabus page for learner MFE #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xitij2000
wants to merge
16
commits into
main
Choose a base branch
from
kshitij/syllabus-tab
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4527449
to
979d613
Compare
…s page for learner MFE
…Syllabus page for learner MFE
… feat: Syllabus page for learner MFE
… fixup! feat: Syllabus page for learner MFE
… fixup! fixup! feat: Syllabus page for learner MFE
pkulkark
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the note about the block cache issue here, otherwise LGTM 👍
- I tested this: Verified that the syllabus tab shows up and functions as expected.
- I read through the code
- Includes documentation
… fixup! fixup! fixup! feat: Syllabus page for learner MFE
… fixup! fixup! fixup! fixup! feat: Syllabus page for learner MFE
… fixup! fixup! fixup! fixup! fixup! feat: Syllabus page for learner MFE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a plugin for the Learner MFE that adds a course tab that displays the syllabus.
syllabus-tab-demo.mp4
Testing instructions
npm install --no-save https://github.com/open-craft/frontend-plugin-syllabus-tab.git#kshitij/syllabus-tab
env.config.jsx
: