Skip to content

feat: Syllabus page for learner MFE #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

xitij2000
Copy link
Member

@xitij2000 xitij2000 commented Mar 21, 2025

This PR implements a plugin for the Learner MFE that adds a course tab that displays the syllabus.

syllabus-tab-demo.mp4

Testing instructions

  • Use the version of the learner MFE that includes the slots this plugin needs: feat: Add slots to add tab links and add mechanism for plugin routes openedx/frontend-app-learning#1645
  • Install this plugin using npm install --no-save https://github.com/open-craft/frontend-plugin-syllabus-tab.git#kshitij/syllabus-tab
  • Use the following contents in env.config.jsx:
    import { pluginSlots, PLUGIN_ROUTES } from '@open-craft/frontend-plugin-syllabus-tab';
    
    const config = {
      PLUGIN_ROUTES: [
       ...PLUGIN_ROUTES,
      ],
      pluginSlots: {...pluginSlots},
    };
    
    export default config;

@xitij2000 xitij2000 force-pushed the kshitij/syllabus-tab branch from 4527449 to 979d613 Compare March 21, 2025 12:06
Copy link
Member

@pkulkark pkulkark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the note about the block cache issue here, otherwise LGTM 👍

  • I tested this: Verified that the syllabus tab shows up and functions as expected.
  • I read through the code
  • Includes documentation

… fixup! fixup! fixup! feat: Syllabus page for learner MFE
… fixup! fixup! fixup! fixup! feat: Syllabus page for learner MFE
… fixup! fixup! fixup! fixup! fixup! feat: Syllabus page for learner MFE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants