Skip to content

Add evaluation details to finally hook stage #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
beeme1mr opened this issue Feb 24, 2025 · 1 comment
Closed

Add evaluation details to finally hook stage #27

beeme1mr opened this issue Feb 24, 2025 · 1 comment

Comments

@beeme1mr
Copy link
Member

Add evaluation details to finally hook stage.

Notes

This breaks the signature of the finally stages based on this spec enhancement. It is not considered a breaking change to the SDK because hooks are marked as experimental in the spec, and the change has no impact on known hooks.

- finally(hookContext, hookHints)
+finally(hookContext, evaluationDetails, hookHints)

Acceptance criteria:

  • finally hook stage modified
  • associated tests

Follow ups:

  • update contribs
This was referenced Mar 19, 2025
Closed
Closed
@brian-chebon brian-chebon mentioned this issue Mar 31, 2025
Merged
ABC2015 pushed a commit that referenced this issue Mar 31, 2025
@brian-chebon
chore: add evaluation details and OpenTelemetry to hooks (#51)
Loading
Loading status checks…
c638263 
## This PR

- Adds evaluation details parameter to the finally hook stage
- Implements OpenTelemetry-compatible telemetry utility functions

### Related Issues

- Fixes Add evaluation details to finally hook stage #27 
- Fixes Add OpenTelemetry-Compatible Telemetry Utility Function #26

Signed-off-by: Brian Chebon <[email protected]>
@brian-chebon brian-chebon mentioned this issue Apr 1, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 1, 2025
@brian-chebon @ABC2015
@beeme1mr @ubabar123 @openfeaturebot
chore: merge development to main (#52)
Loading
Loading status checks…
6b945f3 
## This PR

- Updates the main branch with the changes in development branch
- Adds evaluation details parameter to the finally hook stage
- Implements OpenTelemetry-compatible telemetry utility functions
- updates notification workflows to cover new branches

 ## Related Issues

- Fixes Add evaluation details to finally hook stage #27 
- Fixes Add OpenTelemetry-Compatible Telemetry Utility Function #26

---------

Signed-off-by: Jeremy Andrews <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Usman <[email protected]>
Signed-off-by: ubabar123 <[email protected]>
Signed-off-by: Brian Chebon <[email protected]>
Signed-off-by: OpenFeature Bot <[email protected]>
Co-authored-by: Jeremy Andrews <[email protected]>
Co-authored-by: Michael Beemer <[email protected]>
Co-authored-by: ubabar123 <[email protected]>
Co-authored-by: ABC2015 <[email protected]>
Co-authored-by: OpenFeature Bot <[email protected]>
@ABC2015
Copy link
Contributor

ABC2015 commented Apr 8, 2025

Confirmed that this issue has been address in #51 Closing out this ticket. cc: @brian-chebon

@ABC2015 ABC2015 closed this as completed Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beeme1mr @ABC2015