Skip to content

feat: add custom jsonLogic string evaluators #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
using System;
using JsonLogic.Net;
using Newtonsoft.Json.Linq;

namespace OpenFeature.Contrib.Providers.Flagd.Resolver.InProcess.CustomEvaluators
{
internal class StringEvaluator
{
internal object StartsWith(IProcessJsonLogic p, JToken[] args, object data)
{
return p.Apply(args[0], data).ToString().StartsWith(p.Apply(args[1], data).ToString());
}

internal object EndsWith(IProcessJsonLogic p, JToken[] args, object data)
{
return p.Apply(args[0], data).ToString().EndsWith(p.Apply(args[1], data).ToString());
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using OpenFeature.Constant;
using OpenFeature.Contrib.Providers.Flagd.Resolver.InProcess.CustomEvaluators;
using OpenFeature.Error;
using OpenFeature.Model;

Expand Down Expand Up @@ -58,6 +59,11 @@ internal class JsonEvaluator
internal JsonEvaluator(string selector)
{
_selector = selector;

var stringEvaluator = new StringEvaluator();

EvaluateOperators.Default.AddOperator("starts_with", stringEvaluator.StartsWith);
EvaluateOperators.Default.AddOperator("ends_with", stringEvaluator.EndsWith);
}

internal void Sync(FlagConfigurationUpdateType updateType, string flagConfigurations)
Expand Down
132 changes: 132 additions & 0 deletions test/OpenFeature.Contrib.Providers.Flagd.Test/StringEvaluatorTest.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
using System.Collections.Generic;
using JsonLogic.Net;
using Newtonsoft.Json.Linq;
using OpenFeature.Contrib.Providers.Flagd.Resolver.InProcess.CustomEvaluators;
using Xunit;

namespace OpenFeature.Contrib.Providers.Flagd.Test
{
public class StringEvaluatorTest
{

[Fact]
public void StartsWith()
{
// Arrange
var evaluator = new JsonLogicEvaluator(EvaluateOperators.Default);
var stringEvaluator = new StringEvaluator();
EvaluateOperators.Default.AddOperator("starts_with", stringEvaluator.StartsWith);

var targetingString = @"{""starts_with"": [
{
""var"": [
""color""
]
},
""yellow""
]}";

// Parse json into hierarchical structure
var rule = JObject.Parse(targetingString);

var data = new Dictionary<string, string> { { "color", "yellowcolor" } };

// Act & Assert
var result = evaluator.Apply(rule, data);
Assert.True(result.IsTruthy());

data.Clear();
data.Add("color", "blue");

result = evaluator.Apply(rule, data);
Assert.False(result.IsTruthy());
}

[Fact]
public void EndsWith()
{
// Arrange
var evaluator = new JsonLogicEvaluator(EvaluateOperators.Default);
var stringEvaluator = new StringEvaluator();
EvaluateOperators.Default.AddOperator("ends_with", stringEvaluator.EndsWith);

var targetingString = @"{""ends_with"": [
{
""var"": [
""color""
]
},
""purple""
]}";
Comment on lines +53 to +60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-line strings work great for this. The equivalent tests are so ugly in Java.


// Parse json into hierarchical structure
var rule = JObject.Parse(targetingString);

var data = new Dictionary<string, string> { { "color", "deep-purple" } };

// Act & Assert
var result = evaluator.Apply(rule, data);
Assert.True(result.IsTruthy());

data.Clear();
data.Add("color", "purple-nightmare");

result = evaluator.Apply(rule, data);
Assert.False(result.IsTruthy());
}

[Fact]
public void NonStringTypeInRule()
{
// Arrange
var evaluator = new JsonLogicEvaluator(EvaluateOperators.Default);
var stringEvaluator = new StringEvaluator();
EvaluateOperators.Default.AddOperator("ends_with", stringEvaluator.EndsWith);

var targetingString = @"{""ends_with"": [
{
""var"": [
""color""
]
},
1
]}";

// Parse json into hierarchical structure
var rule = JObject.Parse(targetingString);

var data = new Dictionary<string, string> { { "color", "deep-purple" } };

// Act & Assert
var result = evaluator.Apply(rule, data);
Assert.False(result.IsTruthy());
}

[Fact]
public void NonStringTypeInData()
{
// Arrange
var evaluator = new JsonLogicEvaluator(EvaluateOperators.Default);
var stringEvaluator = new StringEvaluator();
EvaluateOperators.Default.AddOperator("ends_with", stringEvaluator.EndsWith);

var targetingString = @"{""ends_with"": [
{
""var"": [
""color""
]
},
""green""
]}";

// Parse json into hierarchical structure
var rule = JObject.Parse(targetingString);

var data = new Dictionary<string, int> { { "color", 5 } };

// Act & Assert
var result = evaluator.Apply(rule, data);
Assert.False(result.IsTruthy());
}
}
}