-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update OpenFeature.sln #202
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 23 23
Lines 954 954
Branches 105 105
=======================================
Hits 892 892
Misses 38 38
Partials 24 24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess someone must have originally added this manually, then?
@askpt can you run these commands locally, and assuming they do what I expect, check in the results?
git reset @~ --hard
dotnet sln remove test/OpenFeature.E2ETests/OpenFeature.E2ETests.csproj
dotnet sln add test/OpenFeature.E2ETests/OpenFeature.E2ETests.csproj
Signed-off-by: André Silva <[email protected]>
Did this now. Please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this too during a review, but was able to work around it by disabling an extension. I was going to dig into it but assumed it was just me. Thanks.
See: open-feature#202 Signed-off-by: Austin Drenski <[email protected]>
See: #202 Signed-off-by: Austin Drenski <[email protected]>
Signed-off-by: André Silva <[email protected]>
See: #202 Signed-off-by: Austin Drenski <[email protected]> Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]> Signed-off-by: Artyom Tonoyan <[email protected]>
See: open-feature#202 Signed-off-by: Austin Drenski <[email protected]> Signed-off-by: Artyom Tonoyan <[email protected]>
This PR
Related Issues
See log output here:
How to test
Just open VSCode and check it's working again.