Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address issue with newline characters when running Logging Hook Unit Tests on linux #374

Merged
merged 2 commits into from
Feb 17, 2025
Merged

fix: Address issue with newline characters when running Logging Hook Unit Tests on linux #374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b31b8e7
Address issue with newline characters when running on linux
kylejuliandev Feb 8, 2025
9019780
Merge branch 'main' into fix/address-logging-hook-newlines
kylejuliandev Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 36 additions & 45 deletions test/OpenFeature.Tests/Hooks/LoggingHookTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ public async Task BeforeAsync_Without_EvaluationContext_Generates_Debug_Log()
DefaultValue:False

""",
record.Message);
record.Message,
ignoreLineEndingDifferences: true
);
}

[Fact]
Expand Down Expand Up @@ -74,7 +76,9 @@ public async Task BeforeAsync_Without_EvaluationContext_Generates_Correct_Log_Me
DefaultValue:False

""",
record.Message);
record.Message,
ignoreLineEndingDifferences: true
);
}

[Fact]
Expand Down Expand Up @@ -107,15 +111,6 @@ public async Task BeforeAsync_With_EvaluationContext_Generates_Correct_Log_Messa
var record = logger.LatestRecord;
Assert.Equal(LogLevel.Debug, record.Level);

Assert.Contains(
"""
Before Flag Evaluation Domain:client
ProviderName:provider
FlagKey:test
DefaultValue:False
Context:
""",
record.Message);
Assert.Multiple(
() => Assert.Contains("key_1:value", record.Message),
() => Assert.Contains("key_2:False", record.Message),
Expand Down Expand Up @@ -157,7 +152,9 @@ public async Task BeforeAsync_With_No_EvaluationContext_Generates_Correct_Log_Me
Context:

""",
record.Message);
record.Message,
ignoreLineEndingDifferences: true
);
}

[Fact]
Expand Down Expand Up @@ -215,7 +212,9 @@ public async Task ErrorAsync_Without_EvaluationContext_Generates_Correct_Log_Mes
DefaultValue:False

""",
record.Message);
record.Message,
ignoreLineEndingDifferences: true
);
}

[Fact]
Expand Down Expand Up @@ -250,15 +249,6 @@ public async Task ErrorAsync_With_EvaluationContext_Generates_Correct_Log_Messag
var record = logger.LatestRecord;
Assert.Equal(LogLevel.Error, record.Level);

Assert.Contains(
"""
Error during Flag Evaluation Domain:client
ProviderName:provider
FlagKey:test
DefaultValue:False
Context:
""",
record.Message);
Assert.Multiple(
() => Assert.Contains("key_1: ", record.Message),
() => Assert.Contains("key_2:True", record.Message),
Expand Down Expand Up @@ -301,7 +291,9 @@ public async Task ErrorAsync_With_No_EvaluationContext_Generates_Correct_Log_Mes
Context:

""",
record.Message);
record.Message,
ignoreLineEndingDifferences: true
);
}

[Fact]
Expand Down Expand Up @@ -358,7 +350,9 @@ public async Task AfterAsync_Without_EvaluationContext_Generates_Correct_Log_Mes
DefaultValue:False

""",
record.Message);
record.Message,
ignoreLineEndingDifferences: true
);
}

[Fact]
Expand Down Expand Up @@ -393,16 +387,6 @@ public async Task AfterAsync_With_EvaluationContext_Generates_Correct_Log_Messag
var record = logger.LatestRecord;
Assert.Equal(LogLevel.Debug, record.Level);

Assert.Contains(
"""
After Flag Evaluation Domain:client
ProviderName:provider
FlagKey:test
DefaultValue:False
Context:
""",
record.Message);

// .NET Framework uses G15 formatter on double.ToString
// .NET uses G17 formatter on double.ToString
#if NET462
Expand Down Expand Up @@ -452,7 +436,9 @@ public async Task AfterAsync_With_No_EvaluationContext_Generates_Correct_Log_Mes
Context:

""",
record.Message);
record.Message,
ignoreLineEndingDifferences: true
);
}

[Fact]
Expand Down Expand Up @@ -499,8 +485,9 @@ public async Task With_Structure_Type_In_Context_Returns_Qualified_Name_Of_Value
key_1:OpenFeature.Model.Value

""",
message
);
message,
ignoreLineEndingDifferences: true
);
}

[Fact]
Expand Down Expand Up @@ -539,8 +526,9 @@ public async Task Without_Domain_Returns_Missing()
key_1:True

""",
message
);
message,
ignoreLineEndingDifferences: true
);
}

[Fact]
Expand Down Expand Up @@ -579,8 +567,9 @@ public async Task Without_Provider_Returns_Missing()
key_1:True

""",
message
);
message,
ignoreLineEndingDifferences: true
);
}

[Fact]
Expand Down Expand Up @@ -619,8 +608,9 @@ public async Task Without_DefaultValue_Returns_Missing()
key_1:True

""",
message
);
message,
ignoreLineEndingDifferences: true
);
}

[Fact]
Expand Down Expand Up @@ -659,8 +649,9 @@ public async Task Without_EvaluationContextValue_Returns_Nothing()
key_1:

""",
message
);
message,
ignoreLineEndingDifferences: true
);
}

private static string NormalizeLogRecord(FakeLogRecord record)
Expand Down