fix: go-feature-flag sdk - cache key #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Flag evaluation for same flag using different evaluation context properties can lead to cache key collision. Solution: Build cache key considering flag and user evaluation context properties. Signed-off-by: liran2000 <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
approved these changes
Jul 28, 2023
|
CI is failing on lint because of this issue #287 |
Signed-off-by: Thomas Poignant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Flag evaluation for same flag using different evaluation context properties can lead to cache key collision.
Solution:
Build cache key considering flag and user evaluation context properties.
Related Issues
java-sdk PR 369
How to test
Run unit tests.
Can test via go-feature-flag instance, while observing logs.