feat: flagd json eval suite #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
force-pushed
the
chore/json-eval-tests
branch
from
9766ff2 to
e51604c
Compare
toddbaert
commented
Sep 11, 2023
| @@ -614,6 +612,81 @@ func aStringFlagWithKeyIsEvaluatedAsAnIntegerWithDetailsAndADefaultValue( | |||
| }), nil | |||
| } | |||
|
|
|||
| func booleanEvaluationDetails(ctx context.Context) (openfeature.BooleanEvaluationDetails, error) { | |||
There was a problem hiding this comment.
These functions were previously used by 2 suties (caching and evaluation). Now they are just used by one so I've moved/renamed them accordingly.
toddbaert
commented
Sep 11, 2023
| @@ -655,35 +728,6 @@ func theReasonShouldIndicateAnErrorAndTheErrorCodeShouldIndicateATypeMismatchWit | |||
| return nil | |||
| } | |||
|
|
|||
| func aProviderIsRegisteredWithCacheDisabled(ctx context.Context) (context.Context, error) { | |||
There was a problem hiding this comment.
I've commonized this initialization method.
toddbaert
commented
Sep 11, 2023
Comment on lines
+33
to
+36
| func initializeFlagdJsonScenario(ctx *godog.ScenarioContext) { | ||
| ctx.Step(`^a flagd provider is set$`, aFlagdProviderIsSet) | ||
| ctx.Step(`^a string flag with key "([^"]*)" is evaluated with default value "([^"]*)"$`, aFlagdStringFlagWithKeyIsEvaluatedWithDefaultValue) | ||
| ctx.Step(`^a context containing a key "([^"]*)", with value "([^"]*)"$`, aContextContainingAKeyWithValue) | ||
| ctx.Step(`^a context containing a nested property with outer key "([^"]*)" and inner key "([^"]*)", with value "([^"]*)"$`, aContextContainingANestedPropertyWithOuterKeyAndInnerKeyWithValue) | ||
| ctx.Step(`^the returned value should be "([^"]*)"$`, theReturnedValueShouldBe) | ||
| } |
There was a problem hiding this comment.
The entire gherkin test suite here is captured by these 4 tests, which are run "matrix style" with the table values.
toddbaert
commented
Sep 11, 2023
|
|
||
| return got, nil | ||
| } | ||
| func aFlagdProviderIsSet(ctx context.Context) (context.Context, error) { |
There was a problem hiding this comment.
common init method, used by both suites.
toddbaert
force-pushed
the
chore/json-eval-tests
branch
from
e51604c to
fd58f0b
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
chore/json-eval-tests
branch
from
fd58f0b to
0f78059
Compare
bacherfl
reviewed
Sep 11, 2023
bacherfl
reviewed
Sep 11, 2023
bacherfl
approved these changes
Sep 11, 2023
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Kavindu-Dodan
approved these changes
Sep 11, 2023
toddbaert
added a commit
to open-feature/flagd
that referenced
this pull request
Sep 13, 2023
Uses test suite defined [here](https://github.com/open-feature/flagd-testbed/blob/main/gherkin/flagd-json-evaluator.feature) to validate json evaluator behavior end-to-end, by using the test suite added [here](open-feature/go-sdk-contrib#328). --------- Signed-off-by: Todd Baert <[email protected]>
liran2000
pushed a commit
to liran2000/go-sdk-contrib
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: liran2000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
cachingtest. I will add a simplified version laterHere is a PR in flagd using this suite: open-feature/flagd#898