Skip to content

feat: deprecate dedicated flagd in-process provider #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2023
Merged

feat: deprecate dedicated flagd in-process provider #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7df71b9
Add deprecation notice
Kavindu-Dodan Dec 1, 2023
24dea93
Update providers/flagd-in-process/pkg/provider.go
Kavindu-Dodan Dec 5, 2023
00d1d69
Update providers/flagd-in-process/pkg/provider.go
Kavindu-Dodan Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion providers/flagd-in-process/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# In-process Flagd Provider
# DEPRECATED - In-process Flagd Provider

> [!IMPORTANT]
> This provider is DEPRECATED and will be removed soon.
> [flagd provider](../flagd/README.md) now supports in-process flag evaluation and it will be maintained as a single package.

This provider implements parts of the functionality of [Flagd](https://github.com/open-feature/flagd), and follows its
specification for [in-process providers](https://flagd.dev/reference/specifications/in-process-providers/).
Expand Down
2 changes: 2 additions & 0 deletions providers/flagd-in-process/pkg/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ type connectionInfo struct {

type connectionState int

// Deprecated: Please use flagd with WithInProcessResolver option instead of this dedicated provider
type Provider struct {
ctx context.Context
cancelFunc context.CancelFunc
Expand All @@ -80,6 +81,7 @@ type ProviderConfiguration struct {

type ProviderOption func(*Provider)

// Deprecated : Please use flagd with WithInProcessResolver option instead of this dedicated provider
func NewProvider(ctx context.Context, opts ...ProviderOption) *Provider {
ctx, cancel := context.WithCancel(ctx)
provider := &Provider{
Expand Down