Skip to content

fix(deps): move to io.opentelemetry.semconv:opentelemetry-semconv #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

Mahoney
Copy link
Contributor

@Mahoney Mahoney commented Oct 24, 2024

@Mahoney Mahoney requested a review from a team as a code owner October 24, 2024 14:32
@Mahoney Mahoney changed the title Move to io.opentelemetry.semconv:opentelemetry-semconv fix(deps): move to io.opentelemetry.semconv:opentelemetry-semconv Oct 24, 2024
[`io.opentelemetry:opentelemetry-semconv`](https://search.maven.org/artifact/io.opentelemetry/opentelemetry-semconv)
was moved to [`io.opentelemetry.semconv:opentelemetry-semconv`](https://search.maven.org/artifact/io.opentelemetry.semconv/opentelemetry-semconv)
and the former [will be deprecated](open-telemetry/opentelemetry-java#5786).

Signed-off-by: Robert Elliot <[email protected]>
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checking for safety, if this version downgrade can have any bigger impact ;) - but generally this looks good to me

@Mahoney
Copy link
Contributor Author

Mahoney commented Oct 24, 2024

It's not a version downgrade, though it looks like it. They have brought their versioning in line with the spec, and 1.28.0 is the latest version of the OpenTelemetry Semantic Conventions: https://opentelemetry.io/docs/specs/semconv/

If you check search.maven.org, io.opentelemetry:opentelemetry-semconv:1.30.1-alpha (the replaced version) was released on 2023-09-11, whereas io.opentelemetry.semconv:opentelemetry-semconv was released on 2024-10-15.

@beeme1mr
Copy link
Member

Greetings @Mahoney, could you please update this branch? I've set the PR to auto-merge once it's up to date.

@beeme1mr beeme1mr enabled auto-merge (squash) October 31, 2024 16:36
@beeme1mr beeme1mr merged commit 18d2557 into open-feature:main Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants