build: Ensure compatibility with newer Java versions by increasing our java build version #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
okay this will be more complex than expected, the propery was introduced with java 21 - so we do not have this property within our build environment. We could increase the version of our build environment to 21 - than this would not be an issue anymore |
That seems fine to me |
chrfwow
reviewed
Mar 3, 2025
chrfwow
approved these changes
Mar 3, 2025
aepfli
changed the title
aepfli
commented
Mar 3, 2025
Java changed the way how it processes annotations: ``` As of JDK 23, annotation processing is only run with some explicit configuration of annotation processing or with an explicit request to run annotation processing on the javac command line. ``` this messes with lombok, this compiler configuration will change the default behavior, so it works with java 23 Signed-off-by: Simon Schrottner <[email protected]>
chrfwow
approved these changes
Mar 3, 2025
beeme1mr
approved these changes
Mar 3, 2025
toddbaert
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request updates our build java version to 21 - to enable the compiler option
procwhich we need for lombok to be working with newer java versions, see details further belowFurthermore we changing junit to use the bom, rather then specifying a version per artifact.
Java changed the way how it processes annotations:
this messes with lombok, this compiler configuration will change the default behavior, so it works with java 23