build(flagd): OS agnostic flagd provider build #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
guidobrei
commented
Oct 3, 2024
.../flagd/src/test/java/dev/openfeature/contrib/providers/flagd/resolver/process/TestUtils.java
Show resolved
Hide resolved
guidobrei
changed the title
Signed-off-by: Guido Breitenhuber <[email protected]>
Signed-off-by: Guido Breitenhuber <[email protected]>
Signed-off-by: Guido Breitenhuber <[email protected]>
Signed-off-by: Guido Breitenhuber <[email protected]>
guidobrei
force-pushed
the
build/flagd-os-agnostic
branch
from
9c25aa0 to
a7f0fba
Compare
aepfli
approved these changes
Oct 3, 2024
Signed-off-by: Todd Baert <[email protected]>
toddbaert
reviewed
Oct 3, 2024
| @@ -1,184 +0,0 @@ | |||
| { | |||
| "$id": "https://flagd.dev/schema/v0/flags.json", | |||
There was a problem hiding this comment.
I pushed a small change to some test files that use this schema; they now use the pulled/gitignored one.
The test files using this schema only use it for editor support (so editing the schemas locally has editor support) not in actual unit tests.
There was a problem hiding this comment.
Ahh, there they have been used. I was wondering why there have been JSON schemas checked in in resources when they're copied to a different resource directory on build.
toddbaert
approved these changes
Oct 3, 2024
|
This is a helpful additional and makes the POM simpler too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
removes pom.xml dependency on
cpcommand fromflagdprovider maven build.Proposed changes:
Notes
Flagd Provider uses plain
cpcommands in maven build. This causes problems on Windows systems.How to test
./mvnw verifywill build the project (also on windows)