Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flagd): add flag metadata #1151

Merged
merged 6 commits into from
Jan 10, 2025
Merged

feat(flagd): add flag metadata #1151

merged 6 commits into from
Jan 10, 2025

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Jan 7, 2025 •
edited
Loading

This PR

  • adds flag metadata in flagd and flagd web
  • migrates e2e tests to nx jest executor
  • renames providers to flagd
  • bump flagd core version to 1.0

Related Issues

Fixes #1115

How to test

  • npm run e2e
  • npm run test

@beeme1mr beeme1mr linked an issue Jan 7, 2025 that may be closed by this pull request
[flagd] Update in-process resolver to support flag metadata #1115
Closed
@github-actions github-actions bot requested a review from toddbaert January 7, 2025 22:09
@beeme1mr beeme1mr force-pushed the 1115-flagd-update-in-process-resolver-to-support-flag-metadata branch from 76ae337 to e6653d9 Compare January 7, 2025 22:10
@beeme1mr
fix e2e test, minor refactor
3775f07 
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr beeme1mr force-pushed the 1115-flagd-update-in-process-resolver-to-support-flag-metadata branch from 896606a to 3775f07 Compare January 9, 2025 20:03
@beeme1mr
address lint issues
20da8c1 
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr beeme1mr marked this pull request as ready for review January 9, 2025 20:19
@beeme1mr beeme1mr requested a review from a team as a code owner January 9, 2025 20:19
@toddbaert toddbaert self-requested a review January 10, 2025 15:40
@beeme1mr beeme1mr merged commit b1c6d23 into main Jan 10, 2025
6 checks passed
@beeme1mr beeme1mr deleted the 1115-flagd-update-in-process-resolver-to-support-flag-metadata branch January 10, 2025 15:42
This was referenced Jan 9, 2025
Merged
Open
@github-actions github-actions bot mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbaert toddbaert toddbaert approved these changes

@aepfli aepfli Awaiting requested review from aepfli

@lukas-reining lukas-reining Awaiting requested review from lukas-reining

Assignees

@beeme1mr beeme1mr

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flagd] Update in-process resolver to support flag metadata
2 participants
@beeme1mr @toddbaert