feat(ofrep-core): add abort timeout to fetch call #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
commented
Jan 31, 2025
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
commented
Jan 31, 2025
lukas-reining
approved these changes
Feb 2, 2025
toddbaert
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Approved, but consider @lukas-reining 's question about the try/catch.
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
commented
Feb 3, 2025
Signed-off-by: Michael Beemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
timeoutMsoption that defaults to 10 secondsNotes
Uses a signal timeout to aborts slow fetch requests. Here's an interesting article about abort controllers if you're interested.
https://kettanaito.com/blog/dont-sleep-on-abort-controller
Follow-up Tasks
We should consider bumping the min peer version of the OFREP providers to
How to test
Unit tests have been added.