Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): update generated path project.json, jest.config.ts, .eslintrc.json #1236

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

gdegiorgio
Copy link
Contributor

@gdegiorgio gdegiorgio commented Mar 19, 2025

This PR

This PR fix wrong path generation in freshly created provider after npm run generate-provider command

Related Issues

Running test and lint commands on a freshly generated provider ( by using npm run generate-provider) throws errors which makes harder starting contribution on the project

Steps to reproduce:

  • Run npm run generate-provider and create a new example provider
  • Launch npx nx run example:lint and you will get NX Failed to load config "../.eslintrc.json" to extend from. error
  • Launch npx nx run example:test and you will get NX Can't find a root directory while resolving a config file path. error

How to test

Repeat all steps and you will be able to run lint and test command on a freshly created provider

@gdegiorgio gdegiorgio requested a review from a team as a code owner March 19, 2025 12:16
@gdegiorgio gdegiorgio changed the title fix(generator): update generated path project.json, jest.configts, .eslintrc.json fix(generator): update generated path project.json, jest.config.ts, .eslintrc.json Mar 19, 2025
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you for looking into this. NX must have changed the generator behavior recently. FYI @toddbaert

@toddbaert toddbaert self-requested a review March 20, 2025 19:48
@toddbaert
Copy link
Member

Just a reminder to make sure this doesn't add the root project.json as mentioned here.

@gdegiorgio
Copy link
Contributor Author

Just a reminder to make sure this doesn't add the root project.json as mentioned here.

Hi @toddbaert , I've opened #1240 in order to prevent to add generated root project.json in VCS. Currently the problem seems to be @nx/js plugin, we should look further into it.

@toddbaert
Copy link
Member

toddbaert commented Mar 25, 2025

@gdegiorgio I was unable to get this to work in combination with #1240.

I think we need to just "bite the bullet" and finally deal with verdaccio and the project.json that keeps getting added to the root. To remove the infinite loop in all our runs, I've added --exclude=js-sdk-contrib to all our scripts. Otherwise, we get stuck in an infinite cycle. See commit.

Hopefully there is no side effects cc @beeme1mr @lukas-reining

gdegiorgio and others added 4 commits March 25, 2025 13:28
….ts`, `.eslintrc.json`

Signed-off-by: Giovanni De Giorgio <[email protected]>
Signed-off-by: Giovanni De Giorgio <[email protected]>
@toddbaert toddbaert merged commit ea9e62a into open-feature:main Mar 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants