-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(generator): update generated path project.json
, jest.config.ts
, .eslintrc.json
#1236
fix(generator): update generated path project.json
, jest.config.ts
, .eslintrc.json
#1236
Conversation
project.json
, jest.configts
, .eslintrc.json
project.json
, jest.config.ts
, .eslintrc.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thank you for looking into this. NX must have changed the generator behavior recently. FYI @toddbaert
Just a reminder to make sure this doesn't add the root project.json as mentioned here. |
Hi @toddbaert , I've opened #1240 in order to prevent to add generated root |
@gdegiorgio I was unable to get this to work in combination with #1240. I think we need to just "bite the bullet" and finally deal with verdaccio and the project.json that keeps getting added to the root. To remove the infinite loop in all our runs, I've added Hopefully there is no side effects cc @beeme1mr @lukas-reining |
….ts`, `.eslintrc.json` Signed-off-by: Giovanni De Giorgio <[email protected]>
Signed-off-by: Giovanni De Giorgio <[email protected]>
Signed-off-by: Giovanni De Giorgio <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
a2cd60c
to
476e0b0
Compare
This PR
This PR fix wrong path generation in freshly created provider after
npm run generate-provider
commandRelated Issues
Running
test
andlint
commands on a freshly generated provider ( by usingnpm run generate-provider
) throws errors which makes harder starting contribution on the projectSteps to reproduce:
npm run generate-provider
and create a newexample
providernpx nx run example:lint
and you will getNX Failed to load config "../.eslintrc.json" to extend from.
errornpx nx run example:test
and you will getNX Can't find a root directory while resolving a config file path.
errorHow to test
Repeat all steps and you will be able to run lint and test command on a freshly created provider