-
Notifications
You must be signed in to change notification settings - Fork 51
chore(flipt): swap underlying flipt web sdk #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(flipt): swap underlying flipt web sdk #1244
Conversation
Sorry for the delay @markphelps, many of us have been at KubeCon last week. I will look what is wrong with the test :) |
67da35e
to
0355df0
Compare
Thanks @lukas-reining ! I just rebased to sign the DCO. One issue I think is:
I'm importing I think its an issue with the linting tool in that it doesnt see |
Hey @markphelps, the way the repo currently works is, that most providers have their vendor SDK added as Could you change this? We currently have |
@lukas-reining can I get some help fixing these linting issues? im not sure what it wants at this point |
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
This reverts commit 677de8c. Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]> Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Mark Phelps <[email protected]>
4dc7e01
to
f94c90c
Compare
This PR
Closes: #1172
This updates the underlying Flipt Browser SDK to use our new 'isometric' JS SDK which supports both Node and Browser envs.
https://www.npmjs.com/package/@flipt-io/flipt-client-js
The older browser only sdk has been deprecated
Related Issues
Notes
Follow-up Tasks
How to test