Skip to content

fix: otel metric semantic convs #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 19, 2023
Merged

fix: otel metric semantic convs #475

merged 6 commits into from
Jul 19, 2023

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Jul 19, 2023 •
edited
Loading

The keys were wrong 😬

@toddbaert toddbaert requested a review from a team as a code owner July 19, 2023 18:21
@github-actions github-actions bot requested a review from beeme1mr July 19, 2023 18:22
@beeme1mr
Copy link
Member

Perhaps you should move these to the const file since it's the same between metrics and spans.

https://github.com/open-feature/js-sdk-contrib/blob/main/libs/hooks/open-telemetry/src/lib/constants.ts

@toddbaert
Copy link
Member Author

Perhaps you should move these to the const file since it's the same between metrics and spans.

https://github.com/open-feature/js-sdk-contrib/blob/main/libs/hooks/open-telemetry/src/lib/constants.ts

yep

@toddbaert
Copy link
Member Author

@beeme1mr updated.

@toddbaert
fixup: use more consts
d243a29 
Signed-off-by: Todd Baert <[email protected]>
toddbaert added 3 commits July 19, 2023 14:46
@toddbaert
fixup: add link
d7f3b4a 
Signed-off-by: Todd Baert <[email protected]>
@toddbaert
fixup: filename
e3cf14d 
Signed-off-by: Todd Baert <[email protected]>
@toddbaert
fixup: exception
e1f2e3e 
Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert merged commit 6febfb0 into main Jul 19, 2023
@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Merged
@beeme1mr beeme1mr deleted the fix/otel-hook-convs branch July 19, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees

@beeme1mr beeme1mr

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toddbaert @beeme1mr @Kavindu-Dodan