Skip to content

fix: [GO Feature Flag server] handle PROVIDER_NOT_READY from the spec #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix: [GO Feature Flag server] handle PROVIDER_NOT_READY from the spec #505

merged 2 commits into from
Jul 31, 2023

Conversation

thomaspoignant
Copy link
Member

@thomaspoignant thomaspoignant commented Jul 31, 2023 •
edited
Loading

This PR

  • Return an error if we try to evaluate before the provider is ready.
  • Rewrite the tests to use the SDK and not test only the provider.

@thomaspoignant thomaspoignant requested a review from a team as a code owner July 31, 2023 07:22
@thomaspoignant thomaspoignant changed the title fix: [GO Feature Flag server'handle PROVIDER_NOT_READY from the spec fix: [GO Feature Flag server] handle PROVIDER_NOT_READY from the spec Jul 31, 2023
@thomaspoignant thomaspoignant mentioned this pull request Jul 31, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 31, 2023
Closed
@thomaspoignant
Remove unused variable
c198384 
Signed-off-by: Thomas Poignant <[email protected]>
toddbaert
toddbaert approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found this testing style to be better for providers, though maybe some people prefer "unit"-level tests.

Looks good!

@thomaspoignant
Copy link
Member Author

I've found this testing style to be better for providers, though maybe some people prefer "unit"-level tests.

I'll prefer it too, that's what I've done for other providers but this one the 1st one and I haven't done it properly the 1st time :D

@thomaspoignant thomaspoignant merged commit adc2c5a into main Jul 31, 2023
@thomaspoignant thomaspoignant deleted the return-err-if-provider-not-ready branch July 31, 2023 13:52
@github-actions github-actions bot mentioned this pull request Jul 31, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbaert toddbaert toddbaert approved these changes

Assignees

@thomaspoignant thomaspoignant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaspoignant @toddbaert