-
Notifications
You must be signed in to change notification settings - Fork 51
feat: Create a Growthbook server side provider #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create a Growthbook server side provider #938
Conversation
Hey @msamper, great addition, I will have a look tomorrow! |
Hi @msamper, could you please rebase this PR? It should resolve the E2E issue. |
b0201e3
to
52b9510
Compare
@beeme1mr I rebased on the main branch of my fork and it seems like there's still CI issues with the e2e and the lint-test-build. Should I be rebasing on open-feature:main instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @msamper this looks good!
I just have two comments regarding the EvaluationContext
-> Attributes
.
When these are resolved this looks great!
Yes, open-feature:main should be your branch to rebase on @msamper. |
a0467fa
to
f675664
Compare
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
We created a second version of our Node JS SDK that closely mirrors the Dynamic Context paradigm. I updated this PR to use it and fixed the tests. This should resolve the previously outstanding comments |
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
Signed-off-by: Michael Samper <[email protected]>
c7370d4
to
38176b6
Compare
…/growthbook/js-sdk-contrib into msamper/growthbook-node-provider
Signed-off-by: Michael Samper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Signed-off-by: Michael Samper <[email protected]>
Great! Fixed up some variable names and updated the README so it should be good to merge |
Signed-off-by: Michael Samper <[email protected]>
This PR
How to test
Integrate OpenFeature into a test node server and set it up with this new GrowthBook provider. Ensure that GrowthBook flag evaluation works as expected using the OpenFeature API
How to set up OpenFeature with node
OpenFeature.setProvider(new GrowthbookProvider(gbOptions, initOptions))