refactor(telemetry): update telemetry attributes and remove unused evaluation data #1189
+34
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aluation data Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
requested review from
askpt,
kinyoklion,
lukas-reining,
thomaspoignant and
toddbaert
toddbaert
approved these changes
May 15, 2025
askpt
approved these changes
May 15, 2025
…il-function-to-latest-spec
|
Waiting for the OTel JS SDK to support this. |
aepfli
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #1188
Notes
Update the createEvaluationEvent to match the latest OpenTelemetry spec. Unforutnately, this is a breaking change. I'll denote this in the release notes but not in the library version. That's because we're following the experimental OTel spec and the method itself is currently undocumented except from the generated JS Doc.
It's also worth noting that OTel JS SDK event API doesn't currently support object as attribute values. @dyladan will update the OTel SDK.
Follow-up Tasks
Update the ToggleShop.
How to test
npm run test