feat!: errorCode as enum, reason as string #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
requested review from
justinabrahms,
weyert,
beeme1mr,
benjiro,
kinyoklion,
tcarrio,
thomaspoignant,
skyerus,
james-milligan and
rgrassian-split
toddbaert
force-pushed
the
spec/0.5.0
branch
2 times, most recently
from
afbf667 to
8b25707
Compare
toddbaert
commented
Sep 28, 2022
toddbaert
commented
Sep 28, 2022
toddbaert
commented
Sep 28, 2022
toddbaert
commented
Sep 28, 2022
- makes errorCode an enum - makes reason a string - adds errorMessage to resolution/evaluation details Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
spec/0.5.0
branch
from
8b25707 to
e3cb45a
Compare
beeme1mr
reviewed
Sep 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 99.62% 99.81% +0.18%
==========================================
Files 10 14 +4
Lines 539 1099 +560
Branches 84 88 +4
==========================================
+ Hits 537 1097 +560
Misses 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
spec/0.5.0
branch
from
b1dc221 to
2d90910
Compare
kinyoklion
approved these changes
Sep 29, 2022
beeme1mr
approved these changes
Sep 29, 2022
toddbaert
pushed a commit
that referenced
this pull request
Oct 3, 2022
🤖 I have created a release *beep* *boop* --- ## [0.5.0](js-sdk-v0.4.0...js-sdk-v0.5.0) (2022-10-03) This release makes some change to `errors` and `reasons`. Errors are now an enumeration, and reasons are a free-form string. The `EvaluationDetails` and `ResolutionDetails` structures also now include an optional `errorMessage` which, in the case of abnormal execution, corresponds to the `message` property of an underlying error that might have occurred during flag evaluation. This release also included **experimental** web support and **experimental** transaction context propagation. ### ⚠ BREAKING CHANGES * errorCode as enum, reason as string (#244) ### Features * add transaction propagation ([#212](#212)) ([1d251ff](1d251ff)) * errorCode as enum, reason as string ([#244](#244)) ([ce7c4ad](ce7c4ad)) * experimental web support ([#200](#200)) ([fd144bb](fd144bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Oct 7, 2022
lukas-reining
pushed a commit
that referenced
this pull request
Jun 29, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SDK to be conformant to spec v0.5.0
Closes: #242