Skip to content

feat: use interface for events #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 31, 2024
31 changes: 20 additions & 11 deletions packages/client/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -267,43 +267,52 @@ This can be a new repository or included in [the existing contrib repository](ht
You’ll then need to write the provider by implementing the [Provider interface](./src/provider/provider.ts) exported by the OpenFeature SDK.

```ts
import { JsonValue, Provider, ResolutionDetails } from '@openfeature/web-sdk';
import {
AnyProviderEvent,
EvaluationContext,
Hook,
JsonValue,
Logger,
Provider,
ProviderEventEmitter,
ProviderStatus,
ResolutionDetails
} from '@openfeature/web-sdk';

// implement the provider interface
class MyProvider implements Provider {
// Adds runtime validation that the provider is used with the expected SDK
public readonly runsOn = 'client';

public readonly runsOn = 'server';
readonly metadata = {
name: 'My Provider',
} as const;

// Optional provider managed hooks
hooks?: Hook<FlagValue>[];

hooks?: Hook[];
resolveBooleanEvaluation(flagKey: string, defaultValue: boolean, context: EvaluationContext, logger: Logger): ResolutionDetails<boolean> {
// code to evaluate a boolean
}

resolveStringEvaluation(flagKey: string, defaultValue: string, context: EvaluationContext, logger: Logger): ResolutionDetails<string> {
// code to evaluate a string
}

resolveNumberEvaluation(flagKey: string, defaultValue: number, context: EvaluationContext, logger: Logger): ResolutionDetails<number> {
// code to evaluate a number
}

resolveObjectEvaluation<T extends JsonValue>(flagKey: string, defaultValue: T, context: EvaluationContext, logger: Logger): ResolutionDetails<T> {
// code to evaluate an object
}

onContextChange?(oldContext: EvaluationContext, newContext: EvaluationContext): Promise<void> {
// reconcile the provider's cached flags, if applicable
}

status?: ProviderStatus | undefined;
events?: OpenFeatureEventEmitter | undefined;

// implement with "new OpenFeatureEventEmitter()", and use "emit()" to emit events
events?: ProviderEventEmitter<AnyProviderEvent> | undefined;

initialize?(context?: EvaluationContext | undefined): Promise<void> {
// code to initialize your provider
}

onClose?(): Promise<void> {
// code to shut down your provider
}
Expand Down
25 changes: 15 additions & 10 deletions packages/server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,43 +271,48 @@ This can be a new repository or included in [the existing contrib repository](ht
You’ll then need to write the provider by implementing the [Provider interface](./src/provider/provider.ts) exported by the OpenFeature SDK.

```ts
import { JsonValue, Provider, ResolutionDetails } from '@openfeature/server-sdk';
import {
AnyProviderEvent,
EvaluationContext,
Hook,
JsonValue,
Logger,
Provider,
ProviderEventEmitter,
ProviderStatus,
ResolutionDetails
} from '@openfeature/server-sdk';

// implement the provider interface
class MyProvider implements Provider {
// Adds runtime validation that the provider is used with the expected SDK
public readonly runsOn = 'server';

readonly metadata = {
name: 'My Provider',
} as const;

// Optional provider managed hooks
hooks?: Hook<FlagValue>[];

hooks?: Hook[];
resolveBooleanEvaluation(flagKey: string, defaultValue: boolean, context: EvaluationContext, logger: Logger): Promise<ResolutionDetails<boolean>> {
// code to evaluate a boolean
}

resolveStringEvaluation(flagKey: string, defaultValue: string, context: EvaluationContext, logger: Logger): Promise<ResolutionDetails<string>> {
// code to evaluate a string
}

resolveNumberEvaluation(flagKey: string, defaultValue: number, context: EvaluationContext, logger: Logger): Promise<ResolutionDetails<number>> {
// code to evaluate a number
}

resolveObjectEvaluation<T extends JsonValue>(flagKey: string, defaultValue: T, context: EvaluationContext, logger: Logger): Promise<ResolutionDetails<T>> {
// code to evaluate an object
}

status?: ProviderStatus | undefined;
events?: OpenFeatureEventEmitter | undefined;

// implement with "new OpenFeatureEventEmitter()", and use "emit()" to emit events
events?: ProviderEventEmitter<AnyProviderEvent> | undefined;

initialize?(context?: EvaluationContext | undefined): Promise<void> {
// code to initialize your provider
}

onClose?(): Promise<void> {
// code to shut down your provider
}
Expand Down
3 changes: 2 additions & 1 deletion packages/shared/src/events/generic-event-emitter.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Logger, ManageLogger, SafeLogger } from '../logger';
import { ProviderEventEmitter } from './provider-event-emitter';
import { EventContext, EventDetails, EventHandler } from './eventing';
import { AllProviderEvents, AnyProviderEvent } from './events';

Expand All @@ -7,7 +8,7 @@ import { AllProviderEvents, AnyProviderEvent } from './events';
* in the event details.
*/
export abstract class GenericEventEmitter<E extends AnyProviderEvent, AdditionalContext extends Record<string, unknown> = Record<string, unknown>>
implements ManageLogger<GenericEventEmitter<E, AdditionalContext>>
implements ProviderEventEmitter<E>, ManageLogger<GenericEventEmitter<E, AdditionalContext>>
{
protected abstract readonly eventEmitter: PlatformEventEmitter;

Expand Down
2 changes: 2 additions & 0 deletions packages/shared/src/events/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export * from './provider-event-emitter';
export * from './event-utils';
export * from './eventing';
export * from './events';
export * from './generic-event-emitter';

22 changes: 22 additions & 0 deletions packages/shared/src/events/provider-event-emitter.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { ManageLogger } from '../logger';
import { EventContext, EventHandler } from './eventing';
import { AnyProviderEvent } from './events';

/**
* Event emitter to be optionally implemented by providers.
* Implemented by @see OpenFeatureEventEmitter.
*/
export interface ProviderEventEmitter<E extends AnyProviderEvent, AdditionalContext extends Record<string, unknown> = Record<string, unknown>>
extends ManageLogger<ProviderEventEmitter<E, AdditionalContext>>
{
// here we use E, to restrict the events a provider can manually emit (PROVIDER_CONTEXT_CHANGED is emitted by the SDK)
emit(eventType: E, context?: EventContext): void;

addHandler(eventType: AnyProviderEvent, handler: EventHandler): void;

removeHandler(eventType: AnyProviderEvent, handler: EventHandler): void;

removeAllHandlers(eventType?: AnyProviderEvent): void;

getHandlers(eventType: AnyProviderEvent): EventHandler[];
}
4 changes: 2 additions & 2 deletions packages/shared/src/provider/provider.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { EvaluationContext } from '../evaluation';
import { AnyProviderEvent, GenericEventEmitter } from '../events';
import { AnyProviderEvent, ProviderEventEmitter } from '../events';
import { Metadata, Paradigm } from '../types';

/**
Expand Down Expand Up @@ -57,7 +57,7 @@ export interface CommonProvider {
* An event emitter for ProviderEvents.
* @see ProviderEvents
*/
events?: GenericEventEmitter<AnyProviderEvent>;
events?: ProviderEventEmitter<AnyProviderEvent>;

/**
* A function used to shut down the provider.
Expand Down