Skip to content

feat: add otel compatible telemetry signal #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 11, 2025

Conversation

chrfwow
Copy link
Contributor

@chrfwow chrfwow commented Mar 3, 2025

This PR

Adds a function to create an otel compatible telemetry signal

Related Issues

Fixes #125

@chrfwow chrfwow force-pushed the add-telemetry-function branch from a70dae1 to 0950edd Compare March 3, 2025 10:01
@chrfwow chrfwow changed the title add otel compatible telemetry signal feat: add otel compatible telemetry signal Mar 3, 2025
@chrfwow chrfwow marked this pull request as draft March 3, 2025 10:05
@chrfwow chrfwow marked this pull request as ready for review March 3, 2025 11:06
@beeme1mr beeme1mr requested a review from nicklasl March 3, 2025 15:44
@chrfwow chrfwow requested review from nicklasl and beeme1mr March 5, 2025 14:10
@nicklasl
Copy link
Member

nicklasl commented Mar 6, 2025

It would be great to get a little more context on what this PR is about. I think I have a hunch but I also don't want to make conclusions.

I'm also interested in other peoples thoughts on having this helper code for a specific hook packaged into the main SDK. Do we want to consider packaging it in a separate module?

@beeme1mr
Copy link
Member

beeme1mr commented Mar 6, 2025

Hey @nicklasl, the link issue includes a bit more context. Basically, this is a way to easily access an OTel compliant structure that can be used in various ways. That's why we decided to start with a helper function that could live in the SDK itself. We can then create different hooks that folks can use to capture the data however they'd like.

It would live in a sperate package potentially but I'm personally fine included it in the SDK itself. FYI @toddbaert @thomaspoignant @lukas-reining @kinyoklion

@chrfwow chrfwow requested review from nicklasl and aepfli March 7, 2025 11:22
@nicklasl nicklasl merged commit fc0ff3d into open-feature:main Mar 11, 2025
5 checks passed
@chrfwow chrfwow deleted the add-telemetry-function branch March 11, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OpenTelemetry-Compatible Telemetry Utility Function
4 participants