-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add otel compatible telemetry signal #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: christian.lutnik <[email protected]>
a70dae1
to
0950edd
Compare
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
…-telemetry-function
It would be great to get a little more context on what this PR is about. I think I have a hunch but I also don't want to make conclusions. I'm also interested in other peoples thoughts on having this helper code for a specific hook packaged into the main SDK. Do we want to consider packaging it in a separate module? |
Hey @nicklasl, the link issue includes a bit more context. Basically, this is a way to easily access an OTel compliant structure that can be used in various ways. That's why we decided to start with a helper function that could live in the SDK itself. We can then create different hooks that folks can use to capture the data however they'd like. It would live in a sperate package potentially but I'm personally fine included it in the SDK itself. FYI @toddbaert @thomaspoignant @lukas-reining @kinyoklion |
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
This PR
Adds a function to create an otel compatible telemetry signal
Related Issues
Fixes #125