Skip to content

feat: PoC FeatureFlagSource API refactoring [WIP] #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

feat: PoC FeatureFlagSource API refactoring [WIP] #628

wants to merge 15 commits into from

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Apr 30, 2024 •
edited
Loading

Changes

  • introduces new v1beta2 API
  • moves HUB version to v1beta2
  • introduces conversion webhook for FeatureFlagSource
  • introduces validation webhook for FeatureFlagSource
  • uses new HUB version in operator logic
  • supports in-process evaluation in mutating webhook

The current changes are causing a breaking change in the API, but with the usage of conversion webhooks, the conversion is 100% compatible -> see unchanged and still passing E2E tests

Related Issues

Part-of #542

odubajDT added 2 commits April 30, 2024 13:19
@odubajDT
adapt API
94b81f1 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
adapt logic
4bef53c 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT changed the title feat: PoC FeatureFlagSource API refactoring feat: PoC FeatureFlagSource API refactoring [WIP] Apr 30, 2024
odubajDT added 6 commits April 30, 2024 13:57
@odubajDT
fix unit tests
257a57c 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
remove duplicated storageversion
d8e68e9 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
sync api
51bd19f 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
adapt conversion webhook
0a01cbb 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
adapt conversion webhook
7b4fac7 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
com
fa4dd4b 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT force-pushed the ffs-refactoring branch from f520134 to fa4dd4b Compare May 2, 2024 08:00
odubajDT added 7 commits May 2, 2024 10:12
@odubajDT
fix conversion
aeebfd6 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
conversion webhook working
0c54b84 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
conversion
94ebc60 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
sync api
157d583 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
support in process in webhook
f665302 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
sync apis
b1c8328 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix webhook unit tests
9c840d7 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT mentioned this pull request May 2, 2024
Closed
@odubajDT odubajDT closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@odubajDT