Skip to content

fix: fix types for HookContext.{client,provider}_metadata #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix: fix types for HookContext.{client,provider}_metadata #233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63b7808
fix: fix types for HookContext.{client,provider}_metadata
federicobond Nov 3, 2023
e419afc
Merge branch 'main' into fix-types-2
beeme1mr Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions openfeature/hook/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,15 @@
import typing
from dataclasses import dataclass
from enum import Enum
from typing import TYPE_CHECKING

from openfeature.evaluation_context import EvaluationContext
from openfeature.flag_evaluation import FlagEvaluationDetails, FlagType

if TYPE_CHECKING:
from openfeature.client import ClientMetadata
from openfeature.provider.metadata import Metadata


class HookType(Enum):
BEFORE = "before"
Expand All @@ -21,8 +26,8 @@ class HookContext:
flag_type: FlagType
default_value: typing.Any
evaluation_context: EvaluationContext
client_metadata: typing.Optional[dict] = None
provider_metadata: typing.Optional[dict] = None
client_metadata: typing.Optional["ClientMetadata"] = None
provider_metadata: typing.Optional["Metadata"] = None


class Hook:
Expand Down