feat: add suspense, change demos #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
commented
Nov 29, 2023
package.json
Outdated
| @@ -3,7 +3,7 @@ | |||
| "version": "0.1.0", | |||
| "private": true, | |||
| "dependencies": { | |||
| "@openfeature/react-sdk": "^0.0.4-experimental", | |||
| "@openfeature/react-sdk": "file:.yalc/@openfeature/react-sdk", | |||
There was a problem hiding this comment.
Update this before merging
github-merge-queue bot
pushed a commit
to open-feature/js-sdk
that referenced
this pull request
Jan 11, 2024
#698) Adds a few react features: - `<Suspense />` support: components using feature flags will trigger suspense for easy loaders/spinners - Ability to specify name for provider scope: `<OpenFeatureProvider name="my-provider">` > [!IMPORTANT] > Please see [here](open-feature/react-test-app#2) for the latest changes to the demo application using these features (note that we won't be able to merge these demos until this is released). > [!IMPORTANT] > Also note I've added no tests, which is certainly not my MO. I will add them to this PR once there's an agreement on this behavior and implementation. gif from the demo app:  :warning: I want to add another feature here to support re-rendering on context changes. That requires [this](#731) to be merged. --------- Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Michael Beemer <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds demos for new features here: