Skip to content

fix(deps): update datalogic_rs to 3.0.x latest version #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025

Conversation

codetiger
Copy link
Contributor

  • Updated Cargo.toml to use datalogic-rs version 3.0.22.
  • Refactored fractional.rs to implement CustomOperator for better integration with datalogic_rs.
  • Enhanced error handling and logging in fractional.rs and semver.rs.
  • Removed the string_comp.rs file as it is no longer needed.
  • Improved context handling in mod.rs to utilize DataValue directly.

- Updated `Cargo.toml` to use `datalogic-rs` version 3.0.19.
- Refactored `fractional.rs` to implement `CustomOperator` for better integration with `datalogic_rs`.
- Enhanced error handling and logging in `fractional.rs` and `semver.rs`.
- Removed the `string_comp.rs` file as it is no longer needed.
- Improved context handling in `mod.rs` to utilize `DataValue` directly.

Signed-off-by: Harishankar Narayanan <[email protected]>
- Updated `Cargo.toml` to use `datalogic-rs` version 3.0.22.
- Refactored `fractional.rs` and `semver.rs` to implement simple function-based operators instead of custom structs.
- Enhanced error handling and logging in both operator implementations.
- Improved context handling in `mod.rs` to directly utilize `DataValue`.

Signed-off-by: Harishankar Narayanan <[email protected]>
- Updated the `mod.rs` file to replace arena-based object creation with direct JSON manipulation using `serde_json`.
- Simplified the construction of the targeting context by using a JSON object instead of multiple entries.
- Improved the conversion of `EvaluationContextFieldValue` to `serde_json::Value` for better integration with JSON handling.

Signed-off-by: Harishankar Narayanan <[email protected]>
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'll wait to merge until @erenatas has a chance to look at it.

…for clarity

- Renamed the variable for the flagd object to `flagd_props` for clarity.

Signed-off-by: Harishankar Narayanan <[email protected]>
@beeme1mr beeme1mr merged commit 8c9c747 into open-feature:main Apr 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants