-
Notifications
You must be signed in to change notification settings - Fork 2.7k
The project's code coverage is not very high #1038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is definitely good to know, and that's pretty abysmal for a library like us. I'd love to figure out how to get this as part of TravisCI for each patch, definitely want to get these numbers up. |
As we know, there are two popular tools in github, which are Codecov and Coveralls. Recently, I have tested these two kind of tools, then I personally prefer to use the coveralls tool, becase it is more easy to configure, and its result is more compact, so I submit a PR about Coveralls. Here is the PR #1061 test result, |
Well, the result did not proceed as expected, the CI build does triggle the Coveralls, and the coverage report has been sent to the back-end, but it doesn't leave a comments . |
It seems that we should turn on the Furthermore, we should specify the build branches in .travis.yml : branches:
only:
- master @baylesj Please take a look. Can we turn on this button? Seems that it used to be turned on, I don't know why it's turned off now. |
I think it's fine to try building pushed branches. We can see if it becomes a problem. |
Have turned it on, and it works! see the PR #1071. |
Recently, I found that the project's code coverage is not very high. So I plan to improve it by adding some test cases. @baylesj

Here are results from LCOV tool:
The text was updated successfully, but these errors were encountered: