Skip to content

The project's code coverage is not very high #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dota17 opened this issue Sep 27, 2019 · 6 comments
Closed

The project's code coverage is not very high #1038

dota17 opened this issue Sep 27, 2019 · 6 comments

Comments

@dota17
Copy link
Member

dota17 commented Sep 27, 2019

Recently, I found that the project's code coverage is not very high. So I plan to improve it by adding some test cases. @baylesj
Here are results from LCOV tool:
LCOV

@baylesj
Copy link
Contributor

baylesj commented Oct 1, 2019

This is definitely good to know, and that's pretty abysmal for a library like us. I'd love to figure out how to get this as part of TravisCI for each patch, definitely want to get these numbers up.

@dota17
Copy link
Member Author

dota17 commented Oct 17, 2019

As we know, there are two popular tools in github, which are Codecov and Coveralls. Recently, I have tested these two kind of tools, then I personally prefer to use the coveralls tool, becase it is more easy to configure, and its result is more compact, so I submit a PR about Coveralls.

Here is the PR #1061 test result,
image

@dota17
Copy link
Member Author

dota17 commented Oct 18, 2019

Well, the result did not proceed as expected, the CI build does triggle the Coveralls, and the coverage report has been sent to the back-end, but it doesn't leave a comments .
I will keep track of this issue.

@dota17
Copy link
Member Author

dota17 commented Oct 21, 2019

It seems that we should turn on the Build pushed branches button in the Travis CI's settings, because if we want to get the coverage change report, first, we should build pushed branch(usually, it's master branch), and then build pushed pull requests. Finally, the Coveralls can caculate the coverage is increased or decreased by comparing this two build result.

Furthermore, we should specify the build branches in .travis.yml :

branches:
  only:
  - master

image

@baylesj Please take a look. Can we turn on this button? Seems that it used to be turned on, I don't know why it's turned off now.

@baylesj
Copy link
Contributor

baylesj commented Oct 23, 2019

I think it's fine to try building pushed branches. We can see if it becomes a problem.

@dota17
Copy link
Member Author

dota17 commented Oct 26, 2019

Have turned it on, and it works! see the PR #1071.

@dota17 dota17 closed this as completed Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants