Skip to content

add testcases for writerTest [improve coverage] #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 11, 2019
Merged

add testcases for writerTest [improve coverage] #1039

merged 5 commits into from
Oct 11, 2019

Conversation

dota17
Copy link
Member

@dota17 dota17 commented Sep 27, 2019 •
edited
Loading

After add these testcases, the line coverage of the file json_writer.cpp can be increased to 75%.

Before:
image

After:
image

Related issue: #1038

baylesj
baylesj reviewed Oct 1, 2019
View reviewed changes
@dota17 dota17 requested a review from baylesj October 8, 2019 08:58
@dota17
Copy link
Member Author

dota17 commented Oct 10, 2019

image

@baylesj baylesj merged commit ddc0748 into open-source-parsers:master Oct 11, 2019
@dota17 dota17 deleted the writerTest branch October 12, 2019 02:17
dota17 added a commit that referenced this pull request Oct 14, 2019
@dota17
fix clang-format (#1049)
7329223 
fix clang-format for #1039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baylesj baylesj Awaiting requested review from baylesj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dota17 @baylesj