Skip to content

Upgrading to Python 3 #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakirkham opened this issue Nov 3, 2019 · 2 comments
Closed

Upgrading to Python 3 #1081

jakirkham opened this issue Nov 3, 2019 · 2 comments
Assignees

Comments

@jakirkham
Copy link

Is your feature request related to a problem? Please describe.

It appears that Python 2.6 is used in some places like here and here. However Python 2.6 has long since reach its EOL. Not to mention Python 2.7 will not be supported further in the new year.

Describe the solution you'd like

It would be good to move all scripts to support Python 3.

Describe alternatives you've considered

A good compromise would be to get all of the scripts to support Python 2/3, which should continue to work after Python 2 reaches its EOL.

Additional context

Here's the Python EOL guide.

@cdunn2001
Copy link
Contributor

cdunn2001 commented Nov 4, 2019

I've deleted makerelease.py (#1083). Problem solved! 😄

@hjmjohnson, Could you take care of py2.6 in CMake?

Note: We actually run jsontestrunner via Meson in TravisCI, using python3, so I don't think the python version actually matters.

... Oh, we actually still use CMake -- in the AppVeyor build. I think that runs jsontestrunner too -- yes, jsontestrunner_exe.vcxproj -- so we have a test for whatever change you make. I just hate dealing with CMake at all. I wonder if we could use Meson in AppVeyor.

cdunn2001 added a commit to cdunn2001/jsoncpp that referenced this issue Nov 4, 2019
cdunn2001 added a commit that referenced this issue Nov 4, 2019
@hjmjohnson
Copy link
Contributor

OK. Moving to python3 only for support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants