0.10.2 fails to build on armhf and armel

[cinemast]

Hi!

On armhf and armel archs, the debian build is failing due to missing Json::Value::null. Can you help me fix this?

See here:
https://buildd.debian.org/status/fetch.php?pkg=libjsoncpp&arch=armel&ver=0.10.2-2&stamp=1433871006
https://buildd.debian.org/status/fetch.php?pkg=libjsoncpp&arch=armhf&ver=0.10.2-2&stamp=1433871004

Thank you and Greetings.

[cdunn2001]

Ok. Which commit? We tried something recently which might help, and I don't think we merged it. Can you cherry-pick from this PR?

• Ensure Json::Value::null{,Ref} are initialized at compile time. #278

I was reluctant to merge it because I was afraid of breaking Debian. But maybe this will actually fix Debian.

[cdunn2001]

I'll try to put that on a branch...

[cdunn2001]

Ok. Try the private-null branch. Several commits, but the diff is tiny.

[cinemast]

On a ARM board I then get the following error for the private-null branch:

In file included from /home/ubuntu/jsoncpp/include/json/assertions.h:13:0,
                 from /home/ubuntu/jsoncpp/src/lib_json/json_value.cpp:7:
/home/ubuntu/jsoncpp/include/json/config.h:100:14: warning: ISO C++ 1998 does not support ‘long long’ [-Wlong-long]
 typedef long long int Int64;
              ^
/home/ubuntu/jsoncpp/include/json/config.h:101:23: warning: ISO C++ 1998 does not support ‘long long’ [-Wlong-long]
 typedef unsigned long long int UInt64;
                       ^
/home/ubuntu/jsoncpp/src/lib_json/json_value.cpp:27:21: error: ‘const Json::Value& Json::Value::null’ is not a static member of ‘class Json::Value’
 const Value& Value::null = Value::kNull;
                     ^
/home/ubuntu/jsoncpp/src/lib_json/json_value.cpp: In copy constructor ‘Json::Value::CZString::CZString(const Json::Value::CZString&)’:
/home/ubuntu/jsoncpp/src/lib_json/json_value.cpp:244:35: warning: enumeral and non-enumeral type in conditional expression [enabled by default]
                  : other.storage_.policy_);
                                   ^
make[2]: *** [src/lib_json/CMakeFiles/jsoncpp_lib_static.dir/json_value.cpp.o] Error 1
make[1]: *** [src/lib_json/CMakeFiles/jsoncpp_lib_static.dir/all] Error 2
make: *** [all] Error 2

[hchunhui]

In include/json/value.h:164

#if !defined(__ARMEL__)
  /// \deprecated This exists for binary compatibility only. Use nullRef.
  static const Value null;
#endif

So 0.10.2 on armel, Value::null doesn't exist.

On the other hand, the test program uses Value::null unconditionally:
In src/test_lib_json/main.cpp:285

  JSONTEST_ASSERT_EQUAL(Json::Value::null, null_);

That is why the build is failed.

[cdunn2001]

Tonight, I'll remove the use of 'null' from the tests for ARMEL.

[cdunn2001]

@cinemast, It should be fixed now.

@hchunhui, Thanks!

[cinemast]

Looks good. Thank you for your help.

[cdunn2001]

Good. I'll add a signature.

[cinemast]

Sorry false alarm.