-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Meson updates #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meson updates #1124
Conversation
* Make tests optional * Use `files()` for quick sanity checks
* Bump SOVERSION, as some functions were removed and structs were changed, as determined by libabigail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@dota17 thanks for merging, could you tag the latest commit as |
Hi, @SoapGentoo. I haven't been paying any attention to this project for some time. I think we're about to have a new release though, FWIW. Thanks for the Meson fix. It seems like half the Issues here are with Cmake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSONCPP_VERSION_STRING
@@ -9,10 +9,10 @@ | |||
// 3. /CMakeLists.txt | |||
// IMPORTANT: also update the SOVERSION!! | |||
|
|||
#define JSONCPP_VERSION_STRING "1.9.2" | |||
#define JSONCPP_VERSION_STRING "1.9.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1
JSONCPP_VERSION_STRING
JSONCPP_VERSION_STRING |
Hi Chris,
we'd like to disable tests for most users in Gentoo, hence I've made them optional (but still default enabled). I've modernised some parts of the
meson.build
too.