Skip to content

Meson updates #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Meson updates #1124

merged 2 commits into from
Jan 7, 2020

Conversation

SoapGentoo
Copy link
Contributor

Hi Chris,
we'd like to disable tests for most users in Gentoo, hence I've made them optional (but still default enabled). I've modernised some parts of the meson.build too.

@coveralls
Copy link

coveralls commented Dec 21, 2019

Coverage Status

Coverage remained the same at 93.528% when pulling 5977e96 on SoapGentoo:meson-updates into d6c4a8f on open-source-parsers:master.

* Make tests optional
* Use `files()` for quick sanity checks
* Bump SOVERSION, as some functions were removed
  and structs were changed, as determined by
  libabigail.
Copy link
Member

@dota17 dota17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dota17 dota17 merged commit 6bc55ec into open-source-parsers:master Jan 7, 2020
@SoapGentoo SoapGentoo deleted the meson-updates branch January 7, 2020 12:42
@SoapGentoo
Copy link
Contributor Author

@dota17 thanks for merging, could you tag the latest commit as 1.9.3 so we can rely on it in Gentoo?

@cdunn2001
Copy link
Contributor

Hi, @SoapGentoo. I haven't been paying any attention to this project for some time. I think we're about to have a new release though, FWIW. Thanks for the Meson fix. It seems like half the Issues here are with Cmake.

Copy link

@jay0511 jay0511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSONCPP_VERSION_STRING

@@ -9,10 +9,10 @@
// 3. /CMakeLists.txt
// IMPORTANT: also update the SOVERSION!!

#define JSONCPP_VERSION_STRING "1.9.2"
#define JSONCPP_VERSION_STRING "1.9.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

JSONCPP_VERSION_STRING

@jay0511
Copy link

jay0511 commented May 10, 2020

JSONCPP_VERSION_STRING

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants