-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix generation of pkg-config file with absolute includedir/libdir. #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM. |
CMakeLists.txt
Outdated
@@ -1,5 +1,7 @@ | |||
# vim: et ts=4 sts=4 sw=4 tw=0 | |||
|
|||
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_CURRENT_SOURCE_DIR}/cmake") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this line move down a bit? I think there should be a better place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it down. If you have somewhere specific you want it let me know.
Thanks. |
Related to this PR (but also just jsoncpp installation in general), note that work is underway to (hopefully) come up with a design for built-in pkg-config features for CMake's One major hurdle to overcome in the design so far has been the question of input dependency handling. Particularly in a presumptive future where CMake, when generating the build system for some project, may have to contend with dependencies that are defined by a mix of native CMake As a CMake project which also generates and installs |
The CMake variables
CMAKE_INSTALL_LIBDIR
andCMAKE_INSTALL_INCLUDEDIR
are not guaranteed to be relative paths. If they are absolute, an invalid pkg-config file is generated.See https://github.com/jtojnar/cmake-snips#concatenating-paths-when-building-pkg-config-files for more information.