support UTF-8 in old Writers #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had already fixed Value to hold UTF-8 properly, but only the newer StreamWriter was writing UTF-8 properly. Old FasterWriter etc. were using asCString() instead of asString() in Value::writeValue(). Hopefully this change does not break any existing code. Seems unlikely. issue open-source-parsers#240
cdunn2001
force-pushed
the
fix-more-utf8
branch
from
20544ba to
e255ce3
Compare
cdunn2001
added a commit
that referenced
this pull request
Apr 11, 2015
support UTF-8 (specifically, embedded zeroes) in old Writers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had already fixed Value to hold UTF-8 properly, but only the newer
StreamWriter was writing UTF-8 properly.
Old FastWriter etc. were using
asCString()instead ofasString()inValue::writeValue().Hopefully this change does not break any existing code. Seems unlikely.
fix #240