Jsoncpp aliases 2 #868
Merged
Jsoncpp aliases 2 #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmjohnson
approved these changes
Jan 18, 2019
There was a problem hiding this comment.
I approve all of this. My one concern is that this is really just one topic. Personally, I'd like to see it squashed to one commit.
I don't think it's helpful for future developers to need to navigate how you got to the final solution. <-- My 2cents, feel free to ignore.
| using JSONCPP_ISTRINGSTREAM = Json::IStringStream; | ||
| using JSONCPP_OSTRINGSTREAM = Json::OStringStream; | ||
| using JSONCPP_ISTREAM = Json::IStream; | ||
| using JSONCPP_OSTREAM = Json::OStream; |
There was a problem hiding this comment.
Oh yes, I intend to squash it all down to one commit.
It's separate commits just so that it's reviewable steps.
7b1e53c is huge, but it's just a big rename.
There was a problem hiding this comment.
👍 Feel free to merge right after squashing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason for those JSONCPP_STRING etc to be macros.
Let's use real typedefs so the compiler can see them for what they are, and they can have proper namespacing, etc.