Skip to content

COMP: Remove build files for unsupported IDE's #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

hjmjohnson
Copy link
Contributor

The msvc2010 and vs71 IDE's do not support sufficient
C++11 feature sets for jsoncpp.

Remove these build environments.

resolves: #882

Verified

This commit was signed with the committer’s verified signature.
GromNaN Jérôme Tamarelle
The msvc2010 and vs71 IDE's do not support sufficient
C++11 feature sets for jsoncpp.

Remove these build environments.

resolves: open-source-parsers#882
@hjmjohnson hjmjohnson self-assigned this Jan 24, 2019
@hjmjohnson hjmjohnson requested a review from cdunn2001 January 24, 2019 15:03

Verified

This commit was signed with the committer’s verified signature.
GromNaN Jérôme Tamarelle
More robust build environments can be generated from meson
or cmake rather than including those files in every download.
@pratikpc
Copy link

pratikpc commented Feb 2, 2019

I would say it would be an excellent idea to only support CMake as a build system.
CMake can be used by any user to build the type of project of their choice.
CMake also has substantial cross platform compatibility and has no dependency on any other major tool like Python etc. which again is beneficial

@cdunn2001
Copy link
Contributor

We should try to keep msvc2010 support on the 0.10.z versions, but not on master or 1.y.z.

@cdunn2001 cdunn2001 merged commit a732207 into open-source-parsers:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem when compiling with Visual Studio 2010
3 participants