add a new method to insert a new value in an array at specific index. #949

dota17 · 2019-06-21T08:00:12Z

fix issue #691.

baylesj

I'm generally happy with this patch. If you run clang format and update the test, I will merge it in.

src/test_lib_json/main.cpp

include/json/value.h

src/lib_json/json_value.cpp

src/test_lib_json/main.cpp

src/lib_json/json_value.cpp

src/test_lib_json/main.cpp

baylesj · 2019-10-11T18:17:45Z

Thanks for fixing this up, didn't see the latest revision.

src/lib_json/json_value.cpp

baylesj · 2019-10-11T18:26:31Z

If you can fix the merge conflict, we are good to go.

dota17 · 2019-10-12T02:20:08Z

update code, fix the merge conflict and clang-format.

cdunn2001

Good.

cdunn2001 · 2019-10-16T03:22:21Z

I guess you need to rebase this yourself, and maybe squash some commits?

dota17 force-pushed the issue691 branch from 9b232c0 to 4268ae5 Compare June 21, 2019 08:35

add a new method to insert a new value in an array at specific index.

9b0ba50

dota17 force-pushed the issue691 branch from 4268ae5 to 9b0ba50 Compare June 21, 2019 08:53

baylesj requested changes Jun 24, 2019

View reviewed changes

src/test_lib_json/main.cpp Outdated Show resolved Hide resolved

src/test_lib_json/main.cpp Outdated Show resolved Hide resolved

gitpaladin suggested changes Jun 25, 2019

View reviewed changes

include/json/value.h Outdated Show resolved Hide resolved

dota17 force-pushed the issue691 branch 2 times, most recently from 4a9f5c8 to cdd2613 Compare June 26, 2019 12:05

baylesj requested changes Jun 26, 2019

View reviewed changes

src/lib_json/json_value.cpp Outdated Show resolved Hide resolved

src/lib_json/json_value.cpp Outdated Show resolved Hide resolved

dota17 force-pushed the issue691 branch from cdd2613 to 7f5b023 Compare June 27, 2019 00:57

run clang-format.

4b9a293

dota17 force-pushed the issue691 branch from 7f5b023 to 4b9a293 Compare June 27, 2019 12:20

BillyDonahue requested changes Jun 27, 2019

View reviewed changes

dota17 added 5 commits July 1, 2019 20:06

update

8a1d869

update

288028d

update with clang-format

5f574fd

update with clang-format

7095282

update

589b601

BillyDonahue reviewed Jul 4, 2019

View reviewed changes

src/lib_json/json_value.cpp Outdated Show resolved Hide resolved

src/lib_json/json_value.cpp Outdated Show resolved Hide resolved

dota17 added 3 commits July 9, 2019 17:34

modify insert method

d5848ed

update

e0cd860

update

14ac99d

dota17 force-pushed the issue691 branch from cc89138 to 45b8d27 Compare September 5, 2019 13:28

dota17 requested review from BillyDonahue and baylesj September 9, 2019 08:42

run ninja -v -C build-shared clang-format

228f4fc

dota17 force-pushed the issue691 branch from 45b8d27 to 228f4fc Compare September 9, 2019 13:03

baylesj requested changes Sep 16, 2019

View reviewed changes

src/lib_json/json_value.cpp Show resolved Hide resolved

src/test_lib_json/main.cpp Outdated Show resolved Hide resolved

src/test_lib_json/main.cpp Show resolved Hide resolved

src/test_lib_json/main.cpp Outdated Show resolved Hide resolved

dota17 added 3 commits September 26, 2019 15:35

Merge branch 'master' into issue691

674d9cc

update: index > length, return false;

25258ab

update testcase

4765282

dota17 requested a review from baylesj September 26, 2019 08:17

baylesj approved these changes Oct 11, 2019

View reviewed changes

src/lib_json/json_value.cpp Outdated Show resolved Hide resolved

dota17 added 3 commits October 12, 2019 09:59

Merge branch 'master' into issue691

a86c241

update code

e2fdd7c

fix clang-format

d83613e

dota17 requested a review from baylesj October 15, 2019 07:35

Merge branch 'master' into issue691

f2f1ebc

cdunn2001 approved these changes Oct 16, 2019

View reviewed changes

dota17 merged commit bdacfd7 into open-source-parsers:master Oct 16, 2019

dota17 mentioned this pull request Oct 16, 2019

Insert item in array at specific ArrayIndex #691

Closed

dota17 deleted the issue691 branch October 16, 2019 06:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add a new method to insert a new value in an array at specific index. #949

add a new method to insert a new value in an array at specific index. #949

dota17 commented Jun 21, 2019

baylesj left a comment

baylesj commented Oct 11, 2019

baylesj commented Oct 11, 2019

dota17 commented Oct 12, 2019

cdunn2001 left a comment

cdunn2001 commented Oct 16, 2019

add a new method to insert a new value in an array at specific index. #949

add a new method to insert a new value in an array at specific index. #949

Conversation

dota17 commented Jun 21, 2019

baylesj left a comment

Choose a reason for hiding this comment

baylesj commented Oct 11, 2019

baylesj commented Oct 11, 2019

dota17 commented Oct 12, 2019

cdunn2001 left a comment

Choose a reason for hiding this comment

cdunn2001 commented Oct 16, 2019