Skip to content

[BUILD] Fixes warnings of ciso646 in C++17 #3360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

owent
Copy link
Member

@owent owent commented Apr 11, 2025

Fixes #3359

There will be warning when using -std=c++17 in the trunk version of GCC.
The issues were first reported in #3121 (comment) .

Changes

  • Using <version>to import feature checking macros in C++20
  • Using <iso646.h> to avoid warnings in C++17

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner April 11, 2025 03:50
Copy link

netlify bot commented Apr 11, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 84993e1
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6807a434a55acb0008ae8d87

@owent owent mentioned this pull request Apr 11, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (d976876) to head (84993e1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3360      +/-   ##
==========================================
- Coverage   89.57%   89.55%   -0.01%     
==========================================
  Files         210      210              
  Lines        6505     6505              
==========================================
- Hits         5826     5825       -1     
- Misses        679      680       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@owent owent force-pushed the fixes_warnings_when_include_ciso646 branch from 73500ee to 8a36161 Compare April 15, 2025 02:45
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomsonTan ThomsonTan merged commit 4da3647 into open-telemetry:main Apr 23, 2025
66 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Apr 23, 2025
@owent owent deleted the fixes_warnings_when_include_ciso646 branch April 27, 2025 09:47
@marcalff marcalff changed the title Fixes warnings of ciso646 in C++17 [BUILD] Fixes warnings of ciso646 in C++17 May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing <ciso646> when using C++17 or higher C++ version
4 participants