-
Notifications
You must be signed in to change notification settings - Fork 477
[BUILD] Fixes warnings of ciso646 in C++17 #3360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Fixes warnings of ciso646 in C++17 #3360
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3360 +/- ##
==========================================
- Coverage 89.57% 89.55% -0.01%
==========================================
Files 210 210
Lines 6505 6505
==========================================
- Hits 5826 5825 -1
- Misses 679 680 +1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
73500ee
to
8a36161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes warnings of ciso646 in C++17 (open-telemetry#3360)
Fixes #3359
There will be warning when using
-std=c++17
in the trunk version of GCC.The issues were first reported in #3121 (comment) .
Changes
<version>
to import feature checking macros in C++20<iso646.h>
to avoid warnings in C++17For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes